JPAAnnotationProcessor creates map from PersistenceProperty as AnnotationValue instead of String

[nadddy]

Hi,

I am using jboss eap 6.1 and observed that @PersistenceProperty is mapped to hashmap with key as "AnnotationValue" instead of String and EntityMangerImpl is not processing it because it expects key to be String. Is it correct?

Following code snippet reads this annotation (jboss-as-jpa-7.4.0.Final-redhat-19.jar, org.jboss.as.jpa.processor.JPAAnnotationProcessor.java line 304):

Map properties;

AnnotationValue value = annotation.value("properties");

AnnotationInstance[] props = value != null ? value.asNestedArray() : null;

if (props != null) {

  properties = new HashMap();

  for (int source = 0; source < props.length; source++) {

    properties.put(props[source].value("name"), props[source].value("value"));

  }

}

The highlighted object is instance of AnnotationValue and not String which EntityManagerImpl expects and it never gets the correct property. How to pass the property annotation correctly to EntityManagerImpl without changing persistence.xml?

[nadddy]

I found an old issue related to this: https://issues.jboss.org/browse/EJBTHREE-466

I wonder why a simple issue is not fixed for so many years. No annotation can be used without this fix. JBOSS may as well remove the feature if there are not willing to fix.

[jaikiran]

Can you post a relevant example where this is causing problem?

[ctomc]

Well issue you linked has no relation to WildFly / JBoss AS7+ whatsoever.

That jira project was for tracking implementation of EJB3 in older versions of application server and also as standalone project.

Claiming this is an issue based on unrelated bug report is bit silly.

AnnotationValue/AnnotationInstance objects you are referring to are internal Jandex API that WildFly uses for indexing annotations.

This is never exposed to deployment itself, think of it as implementation detail on how we can process annotations in deployment in performant way.

To learn more about jandex look at GitHub - wildfly/jandex: Java Annotation Indexer