Deployments do not wait for OSGi dependencies

[hannu1]

Hi,

We've been facing another issue throughout our update process (described here: Wildfly 10 + JBoss OSGi problems with startup ). In our setup, we have all jars as osgi subsystem capabilities. I know this is not what you recommended arcivanov, but we eager start our bundles and this is the way we control the start order etc. Our webapps (.wars) are placed in the deployments folder and deployment-scanner detects them from there at startup.

The webapps are dependant on the OSGi bundles, but do not manage to resolve all their indirect dependencies. All the direct dependencies listed in the MANIFEST.MF "Dependencies:" -section of the .war are resolved, but some of the indirect dependencies fail to be resolved. This causes an ERROR: Failed to start service xx.war, Caused by: ModuleNotFoundException: deployment.bar:1.2.3 at addExportedPaths(Module.java:1244). The error does not have the same module every time and some starts are even clean without errors. This lead me to believe this was a concurrency issue and I tested starting Wildfly with flag "-Djboss.msc.max.container.threads=1". With single service thread this ERROR never happens, but the whole system is obviously way slower.

I should stress that I performed these tests with the original jboss-modules.jar that comes with Wildfly. Same ERROR occurs with the "fix" we made to jboss-modules though.

It seems the deployments do not wait for indirect dependencies from OSGi bundles to be resolved before concluding that the dependencies were not found. If we let the server boot up and then redeploy those same dependencies they are deployed without issues. Same is true, if we delay deploying our wars by 20 seconds.

[arcivanov]

Hi Hannu,

Sorry for the late reply - I've been away on the West Coast.

There is no such thing as an indirect dependencies per OSGI. Either there are dependencies or there aren't. Please see the comments here that explain this in detail, review your manifests and let me know how it goes: [JBOSGI-794] WAB Fragment resources are not available through host - JBoss Issue Tracker

[hannu1]

Hi,

No worries. I still find it fast, if I get a reply to a forum post in under a week.

What I mean by indirect dependencies is that our WAR is dependent on OSGI bundle deployment.A, through "Dependencies: deployment.A" in MANIFEST.MF file of the .war. The indirect part comes from deployment.A having its set of dependencies through "Import-Package: org.B.package.path". Now our .war is indirectly dependent on "deployment.B".

[arcivanov]

Have you tried using OSGI dependencies directly from your WAR files? You can do that: jbosgi/WebAppTestCase.java at master · jbosgi/jbosgi · GitHub

If you're dependent through Dependencies: it doesn't establish an OSGI dependency.

[hannu1]

I have not tried this. I'm not at work tomorrow, but I will look into it on Monday and report back to you.

It seems weird that our WAR deployments manage to resolve all their dependencies, if they are deployed after Wildfly has already been started. If WARs are deployed during startup, they always fail to deploy after all OSGi bundles have been installed and before the first OSGi bundle is started.

[arcivanov]

I'll see if I can craft a test case. Could you file a bug for this in JBOSGI please?

[hannu1]

[JBOSGI-802] WAR deployments do not always manage to resolve OSGi dependencies during startup - JBoss Issue Tracker

I did the best I could for now. I'll try to add information on Monday.

[hannu1]

I did not have time to test the fix you suggested yet. I  did look through the bug report and couldn't find anything obvious that I forgot. If something is unclear, please ask and I'll add more details.