BaseTransactionalDriverXAConnection.validTransaction method

[arielcarrera]

Sorry if I'm not seeing something... why double check the equality of the object of the transaction?

    public final boolean validTransaction(javax.transaction.Transaction tx) {
        boolean valid = true;


        if (_theTransaction != null) {
            valid = _theTransaction.equals(tx);
            if (!valid) {
                valid = _theTransaction.equals(tx);
            }
        }


        return valid;
    }

https://github.com/jbosstm/narayana/blob/9f42d45b664483c9f0e17cb20122c1d5436ba856/ArjunaJTA/jdbc/classes/com/arjuna/ats/internal/jdbc/BaseTransactionalDriverXAConnection.java#L81

[tomjenkinson]

It does look superfluous to me. Please feel free to raise a JBTM and a pull request to remove the second check.

Thanks for the report!

[arielcarrera]

Ok Thomas, I created the ticket and committed changes in a fork. Tell me if you need a junit test for these little lines removed that doesn't change any function.

[tomjenkinson]

Thanks again