1 2 Previous Next 21 Replies Latest reply on Feb 24, 2006 4:59 PM by Marcin Mieszek

    tomahawk dependency

    Tom Baeyens Master

      i would like to remove the tomahowk dependency, if possible. afaik, file upload is also possible with commons-upload. using commons-upload will give us much more portability between JSF implementations.

      afaik, i removed the dependency quite a while ago and either deleted the tomahawk jar or forgot to do that...

      currently, tomahawk is used for file upload in the admin bean. any other location ?

      marcin, do you think it is possible to use commons fileupload instead of tomahawk ?

      i see in the cvs logs that koentjse updated that lib a few times without a comment.... tssssssss :-) Koen, do you have a dependency on that library ? if yes, can you elaborate on those updates ?

      regards, tom.

        • 1. Re: tomahawk dependency
          Marcin Mieszek Newbie

          Sure, I can use different library to handle file upload. I used MyFaces because I saw it's already in the lib and found it convinient to use.

          I will remove the dependency tonight.

          Marcin

          • 2. Re: tomahawk dependency
            Ronald van Kuijk Master

            If you want paging etc in the ui, the myfaces datatable provides extensions to help a lot with this. Unless we want to develop our own datatable, I think the dependency on tomahawk will be needed. Otherwise the default jsf components need to be used which provide less functionality (no treeview etc...)... it's up to you. So the sun RI library have to be included then instead of the tomahawk jar.

            Ronald

            • 3. Re: tomahawk dependency
              Tom Baeyens Master

              marcin, thanks !

              • 4. Re: tomahawk dependency
                Tom Baeyens Master

                ronald, i would like to wait till it becomes clear what the ADF components can do that oracle recently donated to apache under the name cherokee.

                till we select a UI components package (be it tomahawk or cherokee), we should restrict the use of extensions to a minimum. until there is a default set of extensions.

                if there is an alternative outside of the JSF component extensions, that is for now a better approach, i think.

                of course, to make it fancy we will need these things sooner or later. but postponing that for now will give us better options.

                if heard much more good things about oracles adf then about tomahawk so i would like to wait a bit before we commit ourselves too much to tomahawk...

                regards, tom.

                • 5. Re: tomahawk dependency
                  Koen Aers Master

                  Tom,

                  Do you mean the dependency on the commons-fileupload jar? There is a dependency on it in the upload servlet in the webapp that does the deployment from the gpd.

                  Regards,
                  Koen

                  • 6. Re: tomahawk dependency
                    Tom Baeyens Master

                    koen, so to verify that i understand you correctly, the file upload servlet in the webapp already uses the commons-fileupload.jar, right ?

                    and as far as you know, jbpm doesn't require tomahawk, right ?

                    regards, tom.

                    • 7. Re: tomahawk dependency
                      Tom Baeyens Master

                      marcin, you could see an example of using file upload in the FileUploadServlet.

                      could you also describe for what functionality you needed the file upload ?

                      regards, tom.

                      • 8. Re: tomahawk dependency
                        Marcin Mieszek Newbie

                        I need file upload for deploying new process definition via Administration panel I am working currently on. As I mentioned earlier, it is not a problem to migrate to commons-fileupload and I will do as as soon as I get home back from work. Just need some time :)

                        I did not mean to create any new unnecessary dependencies, I thought that jar stored in lib dir is widely used ;)

                        Please excuse me again if I'm the cause of the problem.

                        Regards,

                        Marcin Mieszek

                        • 9. Re: tomahawk dependency
                          Koen Aers Master

                          Marcin,

                          There is a 'hidden' html page in the webapp, wich is called deploy.html AFAIR that can already be used to do such a thing. It also uses the FileUploadServlet.

                          Cheers,
                          Koen

                          • 10. Re: tomahawk dependency
                            Koen Aers Master

                            Tom,

                            I am indeed not aware of any tomahawk dependencies.

                            Regards,
                            Koen

                            • 11. Re: tomahawk dependency
                              Marcin Mieszek Newbie

                              Hi,

                              I removed dependency on tomahawk in AdminBean. Now upload is based on commons.

                              I created ProcessUploadServlet based on existing UploadServlet. I needed new servlet to make proper forward after deploying process definition.

                              Reagrds,

                              Marcin

                              • 12. Re: tomahawk dependency
                                Koen Aers Master

                                Marcin,

                                I think there is no point in using two servlets for the same thing. So maybe we should use a parameter to distinguish between the two cases (gpd deployment and admin console deployment). In the first case you return a string to the gpd containing errors or 'ok' depending on the result, in the second case you forward to the next webpage depending on the result.
                                What do you think?

                                Regards,
                                Koen

                                • 13. Re: tomahawk dependency
                                  Marcin Mieszek Newbie

                                  I agree with You. The less duplicated code, the easier the maintenance is.

                                  I already use a parameter named "uploadType" to distinguish between uploading process archive or single process definition file (see forms in admin.jsp).

                                  If You take care of setting it to a new value (for instance "gpd"), I'll combine the servlets into one class, unless You want to do it on Your own. Just let me know.

                                  Marcin

                                  • 14. Re: tomahawk dependency
                                    Marcin Mieszek Newbie

                                    Hi,

                                    Tom asked mi to check if we really need two servlets. As I already mentioned I think we don't as their are similar. The odifferences are:
                                    - ProcessUploadServlets redirects to admin.jsp and UploadServlet just prints the status
                                    - ProcessUploadServlet handles uploads both of process definition and while process archive

                                    Is is easy to combine them into one, but I need gpd to provide a parameter "uploadType" so that I will be able to distinguish whether it is gpd deployment or admin console deployment.

                                    I do not know how gpd deployment works and I need Your help in it Koen. After that I can modify the servlets and combine them into one.

                                    Kind regards,

                                    Marcin

                                    1 2 Previous Next