1 2 Previous Next 27 Replies Latest reply on Apr 7, 2009 10:37 AM by dimitris

AS 5 not reliably picking up changes in exploded EAR

maxandersen Mar 9, 2009 5:08 AM

Hi guys,

I'm opening this forum thread based on Ales request in https://jira.jboss.org/jira/browse/JBAS-6590

Kenneth found that when you use an exploded ear on AS 5 then:

1) Seam deployer causes a copy of resources to tmp which by sideeffect makes all changes to the exploded directory (i.e. .xhtml) invisible to the server making a quick turnaround impossible without updating the internaml tmp directory directly.

2) Even when removing the SeamModificationTypeMatcher changes were not being picked up reliably.

I have verified #1 but haven't had time yet to check #2 (trying to get a release out ;) but Kenneth attached a test project for you all to try.

So...what do we do about this ?

And is there tests in AS we can update to add tests for this so we don't loose the hotdeploy functionallity again ?

1. Re: AS 5 not reliably picking up changes in exploded EAR

maxandersen Mar 9, 2009 5:14 AM (in response to maxandersen)

fyi:
Ales gave links to this jira
https://jira.jboss.org/jira/browse/JBSEAM-3702
and http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4203667#4203667
as the cause of the Seam behavior.

I'm quite sure the sideeffect of not picking up changes is not what we wanted here ;)
Actions
2. Re: AS 5 not reliably picking up changes in exploded EAR

maxandersen Mar 9, 2009 5:17 AM (in response to maxandersen)

Kenneth just mailed me saying that #2 is not a problem - the reason it happend was that he in his attempt of trying to get AS to pickup changes had set facelets.REFRESH_PERIOD to 0.

So we are back to only have the problem for Seam apps!
Actions
3. Re: AS 5 not reliably picking up changes in exploded EAR

pmuir Mar 9, 2009 6:53 AM (in response to maxandersen)

I talked to Ales about this, he said that this forcing of a tmp copy shouldn't cause changes not to be seen as the original is still watched for changes and modificationcs copied.
Actions
4. Re: AS 5 not reliably picking up changes in exploded EAR

maxandersen Mar 9, 2009 7:14 AM (in response to maxandersen)

but apparently it is - maybe something specific for facelets ? i.e. if jboss web says it is should look at the tmp/ dir instead of the actual deployed dir and changes to .xhtml is not being copied over ?
Actions
5. Re: AS 5 not reliably picking up changes in exploded EAR

maxandersen Mar 9, 2009 7:26 AM (in response to maxandersen)

I still don't understand why Seam needs to have a tmp for exploded deployment ?
Actions
6. Re: AS 5 not reliably picking up changes in exploded EAR

pmuir Mar 9, 2009 9:36 AM (in response to maxandersen)

"max.andersen@jboss.com" wrote:
I still don't understand why Seam needs to have a tmp for exploded deployment ?

It's a workaround for another problem in JBoss 5 (which I don't quite understand)... Really, it looks to me like all realworld apps will have this problem.
Actions
7. Re: AS 5 not reliably picking up changes in exploded EAR

maxandersen Mar 9, 2009 9:42 AM (in response to maxandersen)

well it only hits seam because that fix (for whatever it is) causes a tmp copy to be created instased of running directly of the files...
Actions
8. Re: AS 5 not reliably picking up changes in exploded EAR

pmuir Mar 9, 2009 3:19 PM (in response to maxandersen)

No, I mean realworld apps will hit the orignal problem, not the hot-deploy problem.
Actions
9. Re: AS 5 not reliably picking up changes in exploded EAR

alesj Mar 11, 2009 5:42 PM (in response to maxandersen)

"max.andersen@jboss.com" wrote:
I still don't understand why Seam needs to have a tmp for exploded deployment ?

It's a very simple problem. ;-)

Some apps, in this case it was Seam Wicket example app,
still want to do some resources lookup at undeploy.
An undeploy which was triggered by the app's dir/archive deletion from deploy/.
But since the app was deleted there is nowhere to do the lookup from.
Unless you do a temp copy. ;-)
And this is what we used to do, and what most app servers still do.

We changed this behavior due to the VFS usage which can handle nested jars in memory.
But we still provide a way to do temp - via jboss-structure.xml.
In this case Seam guys found it too verbose to have to include jboss-structure.xml
in any Seam deployment in JBoss5, hence this feature was developed
== able to recognize deployments and modify the ContextInfo info before the actual/real deployment phase kicks in.

We did temps by-default before, in 4.x, but I don't know how
Tomcat/JBossWeb handled this, since afaik WarDeployer didn't monitor all non-metadata files.
Actions
10. Re: AS 5 not reliably picking up changes in exploded EAR

jason.greene Apr 6, 2009 12:56 PM (in response to maxandersen)

"alesj" wrote:

We did temps by-default before, in 4.x, but I don't know how
Tomcat/JBossWeb handled this, since afaik WarDeployer didn't monitor all non-metadata files.

I asked Remy, and he doesn't know this worked before. However, I can make a very good educated guess, that tomcat just calls getResource on a standard xhtml request, which is of course going to point to the tmp.

One possible solution would be for the deployer to copy *any* changed files in an exploded deployment to the tmp.
Actions
11. Re: AS 5 not reliably picking up changes in exploded EAR

maxandersen Apr 7, 2009 4:07 AM (in response to maxandersen)

We definitely should do this if no other option exists, BUT won't *every* app in the world that is looking up resources during undeploy have this issue ? (i.e. this is not seam specific, it is also an issue for *any* decent sized app that uses its deployed files/dependencies when undeploying)
Actions
12. Re: AS 5 not reliably picking up changes in exploded EAR

dimitris Apr 7, 2009 4:40 AM (in response to maxandersen)

Why not just enable copying to /tmp anyway? As you can see, not doing it requires hacks over hacks to overcome. JBoss 4 did it, and was faster than what we do now.
Actions
13. Re: AS 5 not reliably picking up changes in exploded EAR

maxandersen Apr 7, 2009 5:01 AM (in response to maxandersen)

so JBoss 4 always had two copies ? If yes, then sure - I just thought the value of exploded deployment were that AS used these files *directly*.
Actions
14. Re: AS 5 not reliably picking up changes in exploded EAR

dimitris Apr 7, 2009 5:11 AM (in response to maxandersen)

JBoss 4 copied to tmp whatever was packed, top-level or nested.
Actions

1 2 Previous Next

Go to original post