1 2 Previous Next 19 Replies Latest reply on Jul 20, 2010 11:41 AM by alesj

Seam deployments and hot deployments in AS 5.1.0

jaikiran Aug 7, 2009 10:30 AM

While looking for an workaround for the issue with Seam applications on AS 5.1.0 http://www.jboss.org/index.html?module=bb&op=viewtopic&t=159500, i tried various things without much success. All of the possible workarounds are listed in that thread. Each workaround introduced a new issue with the seam applications.

The ultimate fix for the issue will come from JBDEPLOYER project 2.0.8 GA version which fixed the MetaDataStructureModificationChecker to provide a "cacheFilter" property. So one of the ways to workaround the issue in AS 5.1.0 would be to upgrade the jboss-deployers-vfs jar and jboss-deployers-vfs-spi jar in JBOSS_HOME/lib to use the 2.0.8 GA version and update the JBOSS_HOME/server/conf/bootstrap/profile.xml to use the "cacheFilter" property of MetaDataStructureModificationChecker. As part of this fix, new SPI was introduced in vfs-deployers-spi project. However vfs-deployers has no default implementations (like XmlIncludeVirtualFileFilter, PatternIncludeVirtualFileFilter etc...). These implementations are within the AS code base http://anonsvn.jboss.org/repos/jbossas/branches/Branch_5_x/system/src/main/org/jboss/system/server/profile/basic/XmlIncludeVirtualFileFilter.java

This effectively means that the issue cannot be worked around by replacing the deployers jars, but will require an AS release. That means there is no *practical* workaround for AS 5.1.0 release for Seam applications to fix the issue.

One way to workaround this issue without an AS release would be to port the org.jboss.system.server.profile.basic.XmlIncludeVirtualFileFilter and such filter from the AS, into the deployers project or provide similar default implementations in the deployers project. That way, we could do a new release of the deployers and ask the users to use this newly released deployer jars to replace the ones in AS.

Thoughts? By the way, shouldn't those filter implementations be in the deployers project, in the first place?

P.S: I'll open a separate thread to discuss whether we really need to be doing all this logic for hot deployment or should we follow a simpler approach if possible, like AS 4.x. I know this was discussed in the dev-list once, but i think we need to revisit it again.

1. Re: Seam deployments and hot deployments in AS 5.1.0

alesj Aug 9, 2009 7:27 AM (in response to jaikiran)

"jaikiran" wrote:

Thoughts? By the way, shouldn't those filter implementations be in the deployers project, in the first place?

I'll port some of them (the one's that are generic enough) to Deployers,
plus trying to make them properly implement both filters - VFF and SCF.
Actions
2. Re: Seam deployments and hot deployments in AS 5.1.0

clerum Aug 12, 2009 4:17 PM (in response to jaikiran)

Ales,

Any update on replacement jars so that we can get Seam working with 5.1?
Actions
3. Re: Seam deployments and hot deployments in AS 5.1.0

alesj Aug 13, 2009 5:00 AM (in response to jaikiran)

"clerum" wrote:

Any update on replacement jars so that we can get Seam working with 5.1?

All of them can be found here:
- http://anonsvn.jboss.org/repos/repository.jboss.org/maven2/org/jboss/deployers/

Or you can try building AS 5_x branch, which already has this updated:
- http://anonsvn.jboss.org/repos/jbossas/branches/Branch_5_x/component-matrix/pom.xml
- http://anonsvn.jboss.org/repos/jbossas/branches/Branch_5_x/

But I think the changes, looking from release notes, are mostly internal,
so just changing deployers libs should work.
(there are quite a few component updates, but I think those were already in 5.1 before I updated them in Deployers)
Actions
4. Re: Seam deployments and hot deployments in AS 5.1.0

clerum Aug 13, 2009 10:15 AM (in response to jaikiran)

I hate to be a pain, but I have no clue how to properly build the jar and replace from the first link. I haven't worked with maven before either. Also I don't know which jars need replacing and where they are located in the server. I would really like to see if this fixes the issue though since my problem is so reproducible.

Also I had tried the hudson nightly build 705 a couple days ago and it doesn't work with seam due to some hibernate changes in build 703 http://hudson.jboss.org/hudson/view/JBoss%20AS/job/JBoss-AS-5.1.x/703/changes

From Jaikiran

the hibernate upgrade the 2.2.0 version of Seam is not compatible with AS 5_x branch. Seam's use of org.hibernate.validator.InvalidValue in StatusMessages class causes this issue. The org.hibernate.validator.InvalidValue is no longer available in any of the jar files in the 5_x branch.
Actions
5. Re: Seam deployments and hot deployments in AS 5.1.0

alesj Aug 13, 2009 10:36 AM (in response to jaikiran)

"clerum" wrote:
I hate to be a pain, but I have no clue how to properly build the jar and replace from the first link. I haven't worked with maven before either. Also I don't know which jars need replacing and where they are located in the server. I would really like to see if this fixes the issue though since my problem is so reproducible.

Location in the server: JBOSS_HOME/lib/jboss-deployers-*.*
And then simply browse my first link and replace this jars with the new ones.
Mvn has no specific use in this case - it's just a jar repo.
Actions
6. Re: Seam deployments and hot deployments in AS 5.1.0

clerum Aug 13, 2009 11:15 AM (in response to jaikiran)

Gussing the 2.2.0.M2 version?
Actions
7. Re: Seam deployments and hot deployments in AS 5.1.0

alesj Aug 13, 2009 11:24 AM (in response to jaikiran)

2.0.8.GA
Actions
8. Re: Seam deployments and hot deployments in AS 5.1.0

clerum Aug 13, 2009 11:36 AM (in response to jaikiran)

OK I copied those 9 jars in and I'm still undeploying after about 10 seconds.

I have also made the changes in http://www.seamframework.org/Documentation/WhatHappensWhenYouDeploySeamAppInJBoss5
Actions
9. Re: Seam deployments and hot deployments in AS 5.1.0

clerum Aug 13, 2009 1:28 PM (in response to jaikiran)

OK- I downloaded a new jboss-5.1.0.GA-jdk6.zip and updated the 9 deployer jars. I'm now no longer getting the redeployment loop.

But I am still redeploying after making a change to a .xhtml file. I tried the change from https://jira.jboss.org/jira/browse/JBPAPP-2365

http://fisheye.jboss.org/browse/JBossAS/branches/Branch_5_x/server/src/etc/conf/all/bootstrap/profile.xml?r1=91266&r2=92006

But that didn't work either.

Where should I go from here?
Actions
10. Re: Seam deployments and hot deployments in AS 5.1.0

alesj Aug 13, 2009 3:52 PM (in response to jaikiran)

"clerum" wrote:

I have also made the changes in http://www.seamframework.org/Documentation/WhatHappensWhenYouDeploySeamAppInJBoss5

That change alone unfortunately is not enough:
- http://www.jboss.org/index.html?module=bb&op=viewtopic&t=159500&postdays=0&postorder=asc&start=20, see 2nd post
Actions
11. Re: Seam deployments and hot deployments in AS 5.1.0

alesj Aug 13, 2009 3:55 PM (in response to jaikiran)

"clerum" wrote:

But I am still redeploying after making a change to a .xhtml file.

If this file is not part of metadata locations + picked up by filter,
it shouldn't be re-deployed, it should only be updated.

Jaikiran, can you reproduce this?
Actions
12. Re: Seam deployments and hot deployments in AS 5.1.0

jaikiran Aug 13, 2009 4:32 PM (in response to jaikiran)
"alesj" wrote:

Jaikiran, can you reproduce this?

We just got the seam redeployment issues sorted out on branch 5_x which already includes the 2.0.8 version deployers :) clerum was on #jboss where we got this working. He's going to update this thread with the details.

The only additional thing that he had to do other than just building the AS 5_x branch was to update the profile.xml to include the cacheFilter:

<bean name="ModificationCheckFilter" class="org.jboss.system.server.profile.basic.XmlIncludeVirtualFileFilter"/> <bean name="MetaDataStructureModificationChecker" class="org.jboss.deployers.vfs.spi.structure.modified.MetaDataStructureModificationChecker"> <constructor> <parameter><inject bean="MainDeployer" /></parameter> </constructor> <property name="cache"><inject bean="StructureModCache" /></property> <property name="cacheFilter"><inject bean="ModificationCheckFilter" /></property> <property name="filter"><inject bean="ModificationCheckFilter" /></property> </bean>

We'll have to add this in the 5_x branch by default. clerum with update this thread with the rest of tests and details.
Actions
13. Re: Seam deployments and hot deployments in AS 5.1.0

clerum Aug 14, 2009 12:38 AM (in response to jaikiran)

Jaikiran and I worked on this for a few hours today and did make some progress.

We built from the 5.x branch @ 92198 and made a few tests. Everything works fine once deployed. No loops and the .xhtml changes are picked up.

However in seam the ant explode causes the persistence.xml file to be copied over and this causes 5.x to redeploy (??). This does not happen in 4.2.3GA

pmuir and jaikiran were going to look into this and get back to me when the code as been modified so I can test again.

A frustrating problem but these everyone is being very helpful :-)
Actions
14. Re: Seam deployments and hot deployments in AS 5.1.0

jaikiran Aug 14, 2009 1:30 AM (in response to jaikiran)

"clerum" wrote:

We built from the 5.x branch @ 92198 and made a few tests. Everything works fine once deployed. No loops and the .xhtml changes are picked up.

Which is good news :) because our intention of testing your Seam app was to make sure it did not exhibit unexpected redeployments.

"clerum" wrote:

However in seam the ant explode causes the persistence.xml file to be copied over and this causes 5.x to redeploy (??). This does not happen in 4.2.3GA

Right now, that's actually expected in AS-5. But it's a broader question for AS-5 redeployment logic, which deserves a separate thread http://www.jboss.org/index.html?module=bb&op=viewtopic&t=159869

"clerum" wrote:

A frustrating problem but these everyone is being very helpful :-)

Thanks for your efforts in building AS 5_x from a specific revision and trying out all these tests.
Actions

1 2 Previous Next

Go to original post