-
15. Re: Scaffolding broken for aB123 field names
Hi Anthony,
Could you open a JIRA ticket for this so I can lodge the work against it? You can just reference this forum discussion.
Regards,
Richard.
-
16. Re: Scaffolding broken for aB123 field names
Anthony,
Okay could you please try the latest Metawidget 2.4-SNAPSHOT? We'll still have to make your changes to ForgePropertyStyle (after you open a JIRA), but the Metawidget-generated code should be further improved for 'aFIELD', 'aENTITY', 'aID' etc.
Regards,
Richard.
-
17. Re: Scaffolding broken for aB123 field names
thanks for this snapshot Richard.
Since isCapitalized is not available anymore, I simply commented out the last check that was using it
/*if (field == null && !StringUtils.isCapitalized(propertyName))
{
field = fieldHolder.getField(StringUtils.capitalize(propertyName));
}*/
Then I did another test with the following fields
@Id private @GeneratedValue(strategy = GenerationType.AUTO) Long aID = null; private String abc; private String dEF; private String GHI; @ManyToOne private cENTITY cENTITY;
Note the OanyToOne.
Results:
* forge is still generated broken get/set method names when using its entity command line
* when get/set methods generated by eclipse, then scaffolding is perfect.
One little detail, there is twice the same import cENTITY in the view bean.
-
19. Re: Scaffolding broken for aB123 field names
Thanks for that. Attached a pull request to the JIRA.
Anthony could you please ping Lincoln Baxter to get the 'forge is still generated broken get/set method names when using its entity command line' part fixed? That's outside my jurisdiction
-
20. Re: Scaffolding broken for aB123 field names
Anthony,
Also, could you please elaborate on 'One little detail, there is twice the same import cENTITY in the view bean'?
I'm not seeing this in the org.jboss.forge.scaffold.faces.scenario.shopping.FacesScaffoldShoppingTest, which also builds a ManyToOne relationship with another entity (SubmittedOrder -> Address)?
Regards,
Richard.
-
21. Re: Scaffolding broken for aB123 field names
Also, could you please elaborate on 'One little detail, there is twice the same import cENTITY in the view bean'?
Actually I did some more tests and it seems the problems is not related to a particular naming.
The source of the problem is the *recursive* ManyToOne.
class MyClass{
private MyClass myClass;
...
}
Regards
Anthony
-
23. Re: Scaffolding broken for aB123 field names
I confirm the problem, but is that related to the naming convention ??
I think a new issue should be opened for that.
-
24. Re: Scaffolding broken for aB123 field names
No, it's unrelated. You can open a new issue if you like, but it's such a small fix I just bundled it in with https://github.com/forge/core/pull/184
-
25. Re: Scaffolding broken for aB123 field names
Great !!!!
I'm a fanatic of issue tracking but sure I don't want to flood it with small fixes.
Thank you.