4 Replies Latest reply on Apr 27, 2018 8:38 AM by manovotn

UnsatisfiedResolutionException: WELD-001334: Unsatisfied dependencies for type MovieListerSortedDecorator with qualifiers

okok Apr 27, 2018 7:57 AM

Hello Guys,

im new to DI / WELD SE, and im stuck on this Exceptions for days:

Exception in thread "main" org.jboss.weld.exceptions.UnsatisfiedResolutionException: WELD-001334: Unsatisfied dependencies for type MovieListerSortedDecorator with qualifiers

Could u guys pls tell me what i did wrong? My Code looks like all the Examples i found online imo

public interface GetMovies {
    List<Movie> moviesDirectedBy(String directorName);
    List<String> getAllDirectors();
}

@Default
@Singleton
public class MovieLister implements GetMovies{...}

@Decorator
@Priority(Interceptor.Priority.APPLICATION)
public class MovieListerSortedDecorator implements GetMovies{
    @Inject @Delegate @Default GetMovies movieFinder;


    @Override
    public List<Movie> moviesDirectedBy(String directorName) {
        if(this.movieFinder == null) return new ArrayList<Movie>();
        
        return this.movieFinder.moviesDirectedBy(directorName).stream()
                .sorted((m1, m2) -> m1.getTitle().compareTo(m2.getTitle()))
                .collect(Collectors.toList());             
    }


    @Override
    public List<String> getAllDirectors() {
        if(this.movieFinder == null) return new ArrayList<String>();
        return this.movieFinder.getAllDirectors().stream().sorted().collect(Collectors.toList());
    } 
    
}

    public GetMovies getGetMovies(){
        SeContainerInitializer initializer = SeContainerInitializer.newInstance();
        
        try(SeContainer container = initializer
                .initialize()){
            return container.select(MovieListerSortedDecorator.class).get(); //  return container.select(MovieLister.class).get() << WORKS
            //MovieListerSortedDecorator MovieLister
        }     
        
    }

<beans
   xmlns="http://xmlns.jcp.org/xml/ns/javaee"
   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
   xsi:schemaLocation="
      http://xmlns.jcp.org/xml/ns/javaee
      http://xmlns.jcp.org/xml/ns/javaee/beans_1_1.xsd"
     bean-discovery-mode="all">
    <decorators>
        <class>de.hsos.kbse.movie.impl.MovieListerSortedDecorator</class>
   </decorators>
</beans>

Ty in advance!

1. Re: UnsatisfiedResolutionException: WELD-001334: Unsatisfied dependencies for type MovieListerSortedDecorator with qualifiers

mkouba Apr 27, 2018 8:07 AM (in response to okok)

Hello,
In CDI decoratos cannot be injected/obtained directly. Instead, you should always obtain the bean which is being decorated (i.e. something similar to the code in the comment). However, the method MovieListerSortedDecorator#getGetMovies() looks pretty odd. It's an instance method and you're using CDI SE bootstrap API to start a CDI container there. What exactly are you trying to achieve?
Actions
2. Re: UnsatisfiedResolutionException: WELD-001334: Unsatisfied dependencies for type MovieListerSortedDecorator with qualifiers

okok Apr 27, 2018 8:22 AM (in response to mkouba)

ive got a GUI which reads Directors and u can query through the directors names and see all their movies
the GUI needs an GetMovies
object to do that

getGetMovies is in another class and no part of MovieListerSortedDecorator

MovieLister returns unsorted list's and the MovieListerSortedDecorator returns the list sorted (i know that all of this (the architecture) makes no sense but its for school and this architecture is required)

how can i return an MovieListerSortedDecorator in getGetMovies? (or how can i add the MovieListerSortedDecorator func. to a MovieLister?)

// I know how the Decorator Pattern works and i can implement it without Weld, but im stuck implementing it with Weld
Actions
3. Re: UnsatisfiedResolutionException: WELD-001334: Unsatisfied dependencies for type MovieListerSortedDecorator with qualifiers

manovotn Apr 27, 2018 8:22 AM (in response to okok)
Another note - you are enabling your decorator via both, beans.xml and @Priority.
You should only choose one way (for you @Priority is the go-to option I woud say).

Otherwise, like Martin said, decorators and not to be injected directly, the automatically affect beans with given type (that's what the @Delegate is for).
Hence all calls to those beans will in fact invoke decorator first - which is exactly what you want.

Last but not least, the way you start CDI container is pretty awkward - you only boot to it grab that one bean and immediately close it.
If you wish to use CDI throughout your application, you should boot it once the application starts and shut it down when it exits - CDI container should be running in the meantime.
Here are some reasons why, just from the top of my head:
Re-booting is expensive and gets even more expensive the more beans you have (scanning, instantiating, events,...)
When you re-boot, everything goes from scratch, you loose all the context/state/beans you had (it's unlikely this is desired behaviour)
Using a previously retrieved instance of a bean after you close the CDI container will likely give you exceptions (CDI no longer "lives" hence you are effectively holding a handle to dead instance so to speak)
Actions
4. Re: UnsatisfiedResolutionException: WELD-001334: Unsatisfied dependencies for type MovieListerSortedDecorator with qualifiers

manovotn Apr 27, 2018 8:38 AM (in response to okok)
Beware - the decorator pattern, as defined by GoF, or as defined on Wiki, is not 1-to-1 with what CDI has. It's similar but not the same.

In CDI, you don't want to grab an instance of decorator directly, instead you grab the bean you defined in the first place (GetMovies) and if you invoke a method on that bean, it will automatically invoke decorator since it's applied to it.
Therefore you just do:
MovieLister ml = container.select(MovieLister.class).get(); // grab the bean ml.getAllDirectors(); // this call will in fact automatically invoke MovieListerSortedDecorator.getAllDirectors()
Actions

Go to original post