1 2 Previous Next 25 Replies Latest reply on Jan 24, 2008 1:37 AM by Scott Stark

    Refactoring ServerPeer

    Scott Stark Master

      In looking at where jbossas dependencies start, the org.jboss.jms.server.ServerPeer bean needs major refactoring because of jbossas specific assumptions. Some of the issues are:

      - Its deployed as an mbean based on messaging-service.xml from the jbossas/messaging integration code. However, the xmdesc/ServerPeer-xmbean.xml this references is part of the jboss-messaging.jar. This is a jbossas specific descriptor that should be part of the integration project.

      - It has a direct dependency on org.jboss.mx.loading.UnifiedClassLoader3. This is being used to obtain the ClassLoader ObjectName for use with the org.jboss.system.ServiceCreator. Both are jbossas specific that cannot be in jboss-messaging.jar code.

      - It has destination deployment methods that expose an api which uses a stringified dom Element representation rather than a pojo object model. Not portable and not managable by the profile service.

      - It uses injection of dependencies on typed objects using lookup of jmx Instance attribute based on ObjectNames. This dependency is not expressed explicitly though. So we are both imposing unnecessary implementation details on the providers of the interface as well as not properly expressing the dependency.

      - Aspects are being loaded directly using the org.jboss.aop.AspectXmlLoader to load the aop-messaging-server.xml bundled in jboss-messaging.jar. These aspects configuration should be part of the integration project.

        1 2 Previous Next