For the related TODO in the HAJNDI code we really should be injecting the Naming instance. When I integrate the next jnpserver version I will be switching the naming service configuration to be an mc -beans.xml deployment.
When you change the naming service config to -beans.xml, do you intend to add the injection into DetachedHANamingService, or shall I add a JIRA to handle that myself?
I'll also be converting the hajndi-service.xml back to a -beans.xml for GA, so it's convenient enough for me to add the injection when I do that.
Create the jira and someone will get to it. I'll most likely get to it since I'll need to get the all config running for the smoke/naming tests in jbossas.
Scott, I'd done JBAS-6023 (inject Naming into HA-JNDI) but it got reverted. I'm about to reapply it, but since your extract of the naming service from conf/jboss-service.xml isn't being reapplied, I'm now doing the injection from a legacy mbean rather than a pojo:
<property name="localNamingInstance"><inject bean="jboss:service=NamingBeanImpl" property="namingInstance"/></property>
If you ever redo the pojoization of the naming service, we'll need to change that to:
<property name="localNamingInstance"><inject bean="LocalNamingBean" property="namingInstance"/></property>
in the following files: