13 Replies Latest reply on Jun 7, 2007 1:10 PM by kabirkhan

Removing dependency on concurrent.jar

kabirkhan Apr 24, 2007 3:04 PM

Manik requested that I look into making AOP 2.0 independent of concurrent.jar. I've replaces all references to EDU.oswego classes with their java.util.concurrent counteparts.

All works fine, apart from org.jboss.aop.proxy.ProxyFactory.createInterfaceProxy, which instantiates a org.jboss.aop.proxy.Proxy which has a field of type GUID(), which uses a SynchronizedLong behind the scenes:

ava.lang.NoClassDefFoundError: EDU/oswego/cs/dl/util/concurrent/SynchronizedLong
 at org.jboss.util.id.UID.<clinit>(UID.java:56)
 at org.jboss.util.id.VMID.create(VMID.java:258)
 at org.jboss.util.id.VMID.getInstance(VMID.java:222)
 at org.jboss.util.id.GUID.<init>(GUID.java:64)
 at org.jboss.aop.proxy.ProxyFactory.createInterfaceProxy(ProxyFactory.java:62)
 at org.jboss.test.aop.proxy.ProxyTestCase.testProxy(ProxyTestCase.java:101)

Is making the jboss.util stuff use a java.util.concurrent.atomic.AtomicLong instead an option?

The only other alternative I can see would be to use something other than a GUID in this place.

1. Re: Removing dependency on concurrent.jar

starksm64 Apr 24, 2007 3:27 PM (in response to kabirkhan)

That would mean making the jboss-common jar drop the concurrent dependency. We should create a 2.2.x to do this and leave the 2.0.x common codebase as is.
Actions
2. Re: Removing dependency on concurrent.jar

kabirkhan Apr 24, 2007 4:22 PM (in response to kabirkhan)

Who owns common?
Actions
3. Re: Removing dependency on concurrent.jar

starksm64 Apr 24, 2007 4:30 PM (in response to kabirkhan)

Dimitris, me. I'll start the 2.2.x today.
Actions
4. Re: Removing dependency on concurrent.jar

starksm64 Apr 25, 2007 1:33 AM (in response to kabirkhan)

I created a 2.0 branch and updated the trunk to a 2.2.0.SNAPSHOT that has no dependency on the oswego concurrent classes. Still need to validate the thread pool changes before a release can be made.
Actions
5. Re: Removing dependency on concurrent.jar

kabirkhan Apr 26, 2007 9:31 AM (in response to kabirkhan)

I cannot see the snapshot in the repository?
Actions
6. Re: Removing dependency on concurrent.jar

starksm64 Apr 26, 2007 7:10 PM (in response to kabirkhan)

There is one failure in the updated BasicThreadPool tests that I need to figure out how to implement before the snapshot can be put out. I'll post when its out.
Actions
7. Re: Removing dependency on concurrent.jar

starksm64 Apr 26, 2007 8:04 PM (in response to kabirkhan)

Its been uploaded to https://snapshots.jboss.org/maven2//jboss/jboss-common-core/2.2.0-SNAPSHOT/
Actions
8. Re: Removing dependency on concurrent.jar

kabirkhan Apr 30, 2007 10:36 AM (in response to kabirkhan)

I copied this across to the old thirdparty repository http://repository.jboss.com/jboss/common-core/2.2.0.snapshot/

I don't think there is a way to make the old builds get the snapshots from Maven?
Actions
9. Re: Removing dependency on concurrent.jar

kabirkhan May 4, 2007 11:17 AM (in response to kabirkhan)

The retroed version is at http://repository.jboss.com/jboss/common-core-14/2.2.0.snapshot/
Actions
10. Re: Removing dependency on concurrent.jar

kabirkhan May 12, 2007 8:56 AM (in response to kabirkhan)

The cruisecontrol runs have been failing, while looking like the tests have been run. The underlying problem was that the JDK 1.4 tests were not set up to run against the retroed version of common-core. This has been fixed
Actions
11. Re: Removing dependency on concurrent.jar

kabirkhan Jun 7, 2007 10:05 AM (in response to kabirkhan)

Scott/Dimitris

Are there any plans for a properly tagged common-core 2.2.0 release soon? I want to release aop alpha5 soon
Actions
12. Re: Removing dependency on concurrent.jar

starksm64 Jun 7, 2007 12:39 PM (in response to kabirkhan)

You have been testing the snapshot release? No changes have gone in so no reason why the ga cannot be made.
Actions
13. Re: Removing dependency on concurrent.jar

kabirkhan Jun 7, 2007 1:10 PM (in response to kabirkhan)

It works fine with AOP 2.0. Beyond that I have not done any other tests. The original GUID issue works fine
Actions

Go to original post