5 Replies Latest reply on May 22, 2008 12:06 PM by Paul Gier

    maven-buildmagic-thirdparty-plugin won't pickup source from

    Scott Stark Master

      If I do an install into my local repo of a thirdparty project, and then do a mvn -Pdownload.sources package from thirdparty, I'm not seeing the sources included for this local artifact:

      valkyrie:thirdparty starksm$ mvn -Pdownload.sources package
      [INFO] Scanning for projects...
      WAGON_VERSION: 1.0-beta-2
      [INFO] ------------------------------------------------------------------------
      [INFO] Building JBoss Application Server Thirdparty Build
      [INFO] task-segment: [package]
      [INFO] ------------------------------------------------------------------------
      [INFO] [buildmagic-thirdparty:build-thirdparty {execution: build-thirdparty}]
      [INFO] Copying dependencies to thirdparty directories...
      [INFO] Generating component info files...
      [INFO] Creating libraries.ent...
      [INFO] [buildmagic-thirdparty:build-thirdparty {execution: build-thirparty-testsuite}]
      [INFO] Copying dependencies to thirdparty directories...
      [INFO] Generating component info files...
      [INFO] Creating testsuite-libraries.ent...
      [INFO] [site:attach-descriptor]
      [INFO] Preparing source:jar
      [WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation.
      [INFO] No goals needed for project - skipping
      [INFO] [source:jar {execution: attach-sources}]
      [INFO] ------------------------------------------------------------------------
      [INFO] BUILD SUCCESSFUL
      [INFO] ------------------------------------------------------------------------
      [INFO] Total time: 6 seconds
      [INFO] Finished at: Wed Apr 23 01:47:18 PDT 2008
      [INFO] Final Memory: 21M/38M
      [INFO] ------------------------------------------------------------------------
      valkyrie:thirdparty starksm$ ls -l jboss/metadata/lib/
      total 1984
      -rw-r--r-- 1 starksm admin 1013518 Apr 23 01:47 jboss-metadata.jar
      valkyrie:thirdparty starksm$
      


      Works fine if the thirdparty artifact is in the main jboss repo. Shouldn't the local only artifact also have its source included?


        • 1. Re: maven-buildmagic-thirdparty-plugin won't pickup source f
          Paul Gier Master

          Try using either of these

          mvn -Pdownload-sources

          or
          mvn -Ddownload.sources


          In other words the profile has a dash and the property has a dot. I guess that's confusing. You can change them to be the same string if you want.

          • 2. Re: maven-buildmagic-thirdparty-plugin won't pickup source f
            Scott Stark Master

            Ok, I'm still seeing some sources be excluded. For example, the org.jboss.aop sources:

            [537][valkyrie: thirdparty]$ mvn -Pdownload-sources package
            ...
            [INFO] Scanning for projects...
            WAGON_VERSION: 1.0-beta-2
            [INFO] ------------------------------------------------------------------------
            [INFO] Building JBoss Application Server Thirdparty Build
            [INFO] task-segment: [package]
            [INFO] ------------------------------------------------------------------------
            [INFO] snapshot org.jboss.cache:jbosscache-support:1.3-SNAPSHOT: checking for updates from repository.jboss.org
            [INFO] snapshot org.jboss.cache:jbosscache-support:1.3-SNAPSHOT: checking for updates from snapshots.jboss.org
            [INFO] [dependency:sources {execution: download-sources}]
            [INFO]
            [INFO] The following files have been resolved:
            [INFO] none
            [INFO]
            [INFO] The following files where skipped:
            [INFO] ant:ant:java-source:sources:1.6.5
            ...
            [INFO] org.jboss.aop:jboss-aop-as4-deployer:java-source:sources:2.0.0.CR9
            [INFO] org.jboss.aop:jboss-aop-deployer-jdk50:java-source:sources:2.0.0.CR9
            [INFO] org.jboss.aop:jboss-aop-jboss4-jdk50:java-source:sources:2.0.0.CR9
            [INFO] org.jboss.aop:jboss-aop-jdk50:java-source:sources:2.0.0.CR9
            [INFO] org.jboss.aop:jboss-aop-jdk50-client:java-source:sources:2.0.0.CR9
            [INFO] org.jboss.aop:jboss-standalone-aspect-library-jdk50:java-source:sources:2.0.0.CR9
            [INFO] org.jboss.aop:jrockit-pluggable-instrumentor:java-source:sources:2.0.0.CR9
            [INFO] org.jboss.aop:pluggable-instrumentor:java-source:sources:2.0.0.CR9
            [INFO] org.jboss.aop:resources:java-source:sources:2.0.0.CR9
            ...
            [INFO] [source:jar {execution: attach-sources}]
            [INFO] ------------------------------------------------------------------------
            [INFO] BUILD SUCCESSFUL
            [INFO] ------------------------------------------------------------------------
            [INFO] Total time: 15 seconds
            [INFO] Finished at: Thu May 22 07:00:06 PDT 2008
            [INFO] Final Memory: 26M/47M
            [INFO] ------------------------------------------------------------------------
            [536][valkyrie: thirdparty]$ !ls
            ls jboss/aop/lib/
            jboss-aop-as4-deployer.jar
            jboss-aop-deployer-jdk50.jar
            jboss-aop-jboss4-jdk50.jar
            jboss-aop-jdk50-client.jar
            jboss-aop-jdk50.jar
            jboss-standalone-aspect-library-jdk50.jar
            jrockit-pluggable-instrumentor.jar
            pluggable-instrumentor.jar
            [537][valkyrie: thirdparty]$
            


            What controls this?


            • 3. Re: maven-buildmagic-thirdparty-plugin won't pickup source f
              Paul Gier Master

              Looking at the first aop dep in the list, there aren't any sources in the repository for this.
              http://repository.jboss.org/maven2/org/jboss/aop/jboss-aop-as4-deployer/2.0.0.CR9/

              So that explains why it's not downloaded. When I added the aop stuff, there weren't associated source jars for each of the binary jars.
              http://repository.jboss.org/jboss/aop/2.0.0.CR9/lib/

              I'll work with Kabir to get the sources for these in the repository.

              • 4. Re: maven-buildmagic-thirdparty-plugin won't pickup source f
                Scott Stark Master

                There are source under the maven svn repo for this version though,

                https://svn.jboss.org/repos/repository.jboss.org/maven2/org/jboss/aop/jboss-aop/2.0.0.CR9/

                # jboss-aop-2.0.0.CR9-sources.jar
                # jboss-aop-2.0.0.CR9-sources.jar.md5
                # jboss-aop-2.0.0.CR9-sources.jar.sha1
                # jboss-aop-2.0.0.CR9.jar
                # jboss-aop-2.0.0.CR9.jar.md5
                # jboss-aop-2.0.0.CR9.jar.sha1
                # jboss-aop-2.0.0.CR9.pom
                # jboss-aop-2.0.0.CR9.pom.md5
                # jboss-aop-2.0.0.CR9.pom.sha1
                


                Isn't that where the thirdparty contents are coming from?


                • 5. Re: maven-buildmagic-thirdparty-plugin won't pickup source f
                  Paul Gier Master

                  No, the app server is depending on this one instead:
                  org.jboss.aop:jboss-standalone-aspect-library-jdk50

                  I think they are the same jar except that jboss-aop was built with maven and jboss-standalone-aspect-library-jdk50 was built with ant.