"ips" wrote:
Otherwise, we would have to parse the component names to figure out which type of jboss.web MBean we are dealing with.

The generic mbean to ManagedComponent feature I'm working on will allow the ComponentType to be specified, so it can be unique to the ManagedComponent.

We can have whatever ComponentType we want on a ManagedObject as these are being set explicitly for the current set of MangedObjects. We should setup a Wiki page that lists the standard ManangedComponent names and their ComponentTypes, and we can start updating the ComponentType based on that.

For the GA I have taken a new turn that adds a ManagedMBeanDeploymentFactory notion along with injection into the ManagementView bean to allow one to setup the mapping between mbeans and ManagedDeployment/ManagedComponents. Its not completely finished or tested, but an example of getting some of the web app/servlet components are:

 <bean name="WarManagerManagedDeploymentFactory"
 class="org.jboss.profileservice.management.ProxyManagedDeploymentFactory">
 <property name="factoryName">WarManager</property>
 <property name="compType">MBean</property>
 <property name="compSubtype">WebApplicationManager</property>
 <property name="pattern">jboss.web:host=localhost,type=Manager,*</property>
 <property name="patternKey">path</property>
 </bean>

 <bean name="WebModuleManagedDeploymentFactory"
 class="org.jboss.profileservice.management.ProxyManagedDeploymentFactory">
 <property name="factoryName">WebModule</property>
 <property name="compType">MBean</property>
 <property name="compSubtype">WebApplication</property>
 <property name="pattern">jboss.web:J2EEApplication=none,J2EEServer=none,j2eeType=WebModule,*</property>
 <property name="patternKey">name</property>
 <property name="componetInfo">
 <map keyClass="java.lang.String" valueClass="java.lang.String">
 <!-- Process the servlets components -->
 <entry>
 <key>servlets</key>
 <value>MBean:Servlet</value>
 </entry>
 </map>
 </property>
 </bean>

Also note that ManagedMBeanDeploymentFactory deployments can be done anywhere as long as there is a dependency on the ManagementView which defines the incallback/uncallback context injection for this type:

 <bean name="ManagementView" class="org.jboss.profileservice.management.ManagementViewImpl">
...
 <!-- Accept any implementor of ManagedMBeanDeploymentFactory -->
 <incallback method="addManagedMBeanDeployments"/>
 <uncallback method="removeManagedMBeanDeployments"/>
 </bean>

I am currently looking into a way to provide overrides for statistic properties. The code mentions supporting annotation metadata on MBeanInfo Descriptors, however that would require patching tomcat to provide this info.

Another problem I am having is that the tomcat mbeans are not invokable via the KernelDispatcher, I guess because the MC was not the creation source of this mbean. So, I guess this needs a special mbean dispatcher:

Caused by: java.lang.IllegalArgumentException: No such context: jboss.web:host=localhost,path=/jmx-console,type=Manager
 at org.jboss.kernel.plugins.registry.basic.BasicKernelBus.execute(BasicKernelBus.java:51)
 at org.jboss.kernel.plugins.registry.basic.BasicKernelBus.get(BasicKernelBus.java:59)
 at org.jboss.profileservice.management.KernelBusRuntimeComponentDispatcher.get(KernelBusRuntimeComponentDispatcher.java:85)

"jason.greene@jboss.com" wrote:
So, I guess this needs a special mbean dispatcher

Another issue that needs to be solved is association of a WAR deployment managed object to a tomcat Manager JMX entry. One possible way to correlate is to use the docBase property on the JSR-77 WebModule object.

Even better would be a way to set the context root on the ManagedDeployment of the WAR.

Is there an easy way for the AbstractWarDeployer to add a new ManagedProperty to the ManagedDeployment?

I have committed the new mbean dispatcher, and also introduced a temporary ViewUse default property, which I have set to statistic (until we come up with a better solution).

I also added a simple test case that verifies properties are working for all web component types (JMXMappingUnitTestCase).

"jason.greene@jboss.com" wrote:

Even better would be a way to set the context root on the ManagedDeployment of the WAR.

"emuckenhuber" wrote:

Hmm, can't we just connect the creation of statistic MBeans to a ManagedObject/ManagedComponent type?
So instead of having a pattern to do a jmx lookup it would be based on e.g. a JBossWebMetaData component when doing the processing in ManagementView. This would have the benefit that it could get the required information from the MO/component and has it's reference to the ManagedDeployment.

"jason.greene@jboss.com" wrote:
I am currently looking into a way to provide overrides for statistic properties. The code mentions supporting annotation metadata on MBeanInfo Descriptors, however that would require patching tomcat to provide this info.