1 2 Previous Next 21 Replies Latest reply on Apr 3, 2007 9:30 AM by Paul Gier

    Remove eclipse files from SVN?

    Adrian Brock Master

      Kevin suggested we remove the eclipse files from SVN.

      I don't think this is a good idea. I'd rather they were automatically generated
      (as part of the normal build) and checked in with every change.

      If the SVN projects don't have eclipse project files then we have no hope
      of getting an eclipse project set to work (even when the SVN plugin handles properly :-).

        • 1. Re: Remove eclipse files from SVN?
          Kevin Conner Master

          If we do not remove them then they will always show up as modified and will overwrite the current versions on an update.

          What is wrong with relying on the generated ones?

          I agree that the first step is to get the generated ones to work, which we are doing :-)

          • 2. Re: Remove eclipse files from SVN?
            Kevin Conner Master

            Of course the other issue would be when I change the settings to reflect my preferences and overwrite yours :-)

            • 3. Re: Remove eclipse files from SVN?
              Adrian Brock Master

               

              "Kevin.Conner@jboss.com" wrote:
              If we do not remove them then they will always show up as modified and will overwrite the current versions on an update.

              What is wrong with relying on the generated ones?


              Eclipse has a feature where you can set up an eclipse project set.
              In principle, I should be able to create a new eclipse workspace then
              import this file:
              http://anonsvn.jboss.org/repos/jbossas/projects/microcontainer/trunk/build/eclipse.psf

              But if there are no .project files, it ain't going to work.

              • 4. Re: Remove eclipse files from SVN?
                Adrian Brock Master

                 

                "Kevin.Conner@jboss.com" wrote:
                If we do not remove them then they will always show up as modified and will overwrite the current versions on an update.


                They should only appear changed if somebody modifies the pom/dependencies.

                In fact, this is a good thing. In princple, I should be able to resync with SVN
                and get a working build. Instead, to get a working eclipse build after a change,
                I've got to:

                1) Resync SVN
                2) Shell out and rebuild
                3) Run eclipse:eclipse
                4) Refresh the workspace

                • 5. Re: Remove eclipse files from SVN?
                  Adrian Brock Master

                   

                  "Kevin.Conner@jboss.com" wrote:
                  Of course the other issue would be when I change the settings to reflect my preferences and overwrite yours :-)


                  Preferences shouldn't be at the project level.

                  Although, it would be interesting to test whether we can put the JBoss source rules
                  in the project specific .settings file? Or whether eclipse:eclipse would just overwrite it?

                  • 6. Re: Remove eclipse files from SVN?
                    Kevin Conner Master

                     

                    "adrian@jboss.org" wrote:
                    But if there are no .project files, it ain't going to work.

                    True, but with our subversion repository do we need this?

                    • 7. Re: Remove eclipse files from SVN?
                      Kevin Conner Master

                       

                      "adrian@jboss.org" wrote:
                      n fact, this is a good thing. In princple, I should be able to resync with SVN
                      and get a working build. Instead, to get a working eclipse build after a change,
                      I've got to:

                      1) Resync SVN
                      2) Shell out and rebuild
                      3) Run eclipse:eclipse
                      4) Refresh the workspace

                      Forget step 2 but the rest would apply.

                      So what happens if I use something else in my builds, e.g. checkstyle, pmd etc :-)

                      • 8. Re: Remove eclipse files from SVN?
                        Kevin Conner Master

                         

                        "adrian@jboss.org" wrote:
                        Preferences shouldn't be at the project level.

                        But they can be :-)
                        "adrian@jboss.org" wrote:
                        Although, it would be interesting to test whether we can put the JBoss source rules in the project specific .settings file? Or whether eclipse:eclipse would just overwrite it?

                        We could always have the build create the workspace and prepopulate checktyle/formatting rules :-)

                        • 9. Re: Remove eclipse files from SVN?
                          Adrian Brock Master

                           

                          "Kevin.Conner@jboss.com" wrote:
                          "adrian@jboss.org" wrote:
                          But if there are no .project files, it ain't going to work.

                          True, but with our subversion repository do we need this?


                          Your kidding aren't you? :-)

                          Compare:
                          1) Start eclipse
                          2) Import eclipse.psf
                          3) mvn build (optional - to pulldown thirdparty - if not already present)

                          With
                          1) svn co ...
                          2) mvn build and eclipse:eclipse
                          3) create a separate workspace
                          4) import projects

                          Or for a refresh
                          1) resync with eclipse (project files are already up-to-date)
                          2) mvn build (optional - to pulldown thirdparty - if not already present)

                          versus
                          1) resync with eclipse
                          2) mvn build and eclipse:eclipse
                          3) refresh the eclipse workspace
                          4) Fight with eclipse's broken incremental compiler until it builds the thing correctly :-)

                          • 10. Re: Remove eclipse files from SVN?
                            Kevin Conner Master

                             

                            "adrian@jboss.org" wrote:
                            Your kidding aren't you? :-)

                            Not at all. I would rather have something build automatically than fight with the settings that someone else checked in :-)

                            I have worked on many projects where the classpath/project/settings were checked in and it was always a pain.

                            BTW what do you think about generating the workspace? :-)

                            • 11. Re: Remove eclipse files from SVN?
                              Kevin Conner Master

                               

                              "adrian@jboss.org" wrote:
                              2) mvn build and eclipse:eclipse

                              BTW You do not need to do a mvn build, mvn eclipse:eclipse will suffice :-)

                              You did forget mvn eclipse:add-maven-repo though ;-)

                              • 12. Re: Remove eclipse files from SVN?
                                Adrian Brock Master

                                 

                                "Kevin.Conner@jboss.com" wrote:

                                BTW what do you think about generating the workspace? :-)


                                I hate scripts. I always preferred make (declaritive) to ant (scripts).

                                I want to download things and have it work, not waste time
                                baby sitting eclipse builds (like I do now :-( )
                                or remembering what order of magic incantations I need to get to a working build
                                (besides rm -rf * and start again :-)

                                If the eclipse:eclipse was part of every build when somebody changed the pom
                                then these would automatically get checked in with the pom update (even
                                if they don't use eclipse) and it would be end of story.

                                Well, unless you need to do the mvn build to pull down thirdparty dependencies
                                and then you are back to figuring out how to get eclipse to build it,
                                i.e. whether it is a broken build or eclipse being stupid again. :-)

                                • 13. Re: Remove eclipse files from SVN?
                                  Adrian Brock Master

                                  Basically, I want the builds to be as incremental/seamless as possible,
                                  that means they must be declaritive.

                                  I don't mind doing full rebuilds if somebody does a major refactoring
                                  (which on some projects is every couple of weeks :-)
                                  but they should be the exception.

                                  If we get a jboss build down to "import this eclipse project set"
                                  and use eclipse's synchronization tool, you only need to do the full maven build
                                  for a full release or a change in pom that introduces a new dependency
                                  (and all the messing about that entails - including broken builds) I would be very happy.

                                  • 14. Re: Remove eclipse files from SVN?
                                    Adrian Brock Master

                                     

                                    "adrian@jboss.org" wrote:
                                    "Kevin.Conner@jboss.com" wrote:
                                    If we do not remove them then they will always show up as modified and will overwrite the current versions on an update.


                                    They should only appear changed if somebody modifies the pom/dependencies.


                                    I just tested this and it doesn't work.
                                    The eclipse:eclipse plugin is not generating the files consistently.

                                    e.g. I got this diff without changing anything
                                    Index: /home/ejort/microcontainer/aop-mc-int/.project
                                    ===================================================================
                                    --- /home/ejort/microcontainer/aop-mc-int/.project (revision 62024)
                                    +++ /home/ejort/microcontainer/aop-mc-int/.project (working copy)
                                    @@ -2,9 +2,9 @@
                                     <name>jboss-aop-mc-int</name>
                                     <comment>JBoss Microcontainer</comment>
                                     <projects>
                                    + <project>jboss-container</project>
                                     <project>jboss-kernel</project>
                                     <project>jboss-dependency</project>
                                    - <project>jboss-container</project>
                                     </projects>
                                     <buildSpec>
                                     <buildCommand>
                                    


                                    I guess it is using HashSets or HashMaps internally so the order from the pom
                                    is not being conserved.

                                    V.Annoying :-)

                                    1 2 Previous Next