6 Replies Latest reply on Sep 3, 2008 4:10 AM by Adrian Brock

    Some Maven related changes

    Paul Gier Master

      I'd like to make a couple of changes in the microcontainer build. The first is to change the parent/aggregate relationship so that the pom in the root directory functions as the parent. This will be more like how the app server build and the aop maven build are set up, and more like how maven builds itself. The build subdirectory will then be just for creating the combined jar files.

      Also, is there any reason not to change the directory names to follow the maven conventions? Currently we have src/main and src/tests. I'd like to change these to src/main/java and src/test/java.

        • 1. Re: Some Maven related changes
          Ales Justin Master

           

          "pgier" wrote:
          I'd like to make a couple of changes in the microcontainer build. The first is to change the parent/aggregate relationship so that the pom in the root directory functions as the parent. This will be more like how the app server build and the aop maven build are set up, and more like how maven builds itself. The build subdirectory will then be just for creating the combined jar files.

          Isn't app server similar to what we have in MC?
          Component-matrix ~ build?

          But yeah, fine with me.
          Adrian (as now my first officer :-)?

          "pgier" wrote:

          Also, is there any reason not to change the directory names to follow the maven conventions? Currently we have src/main and src/tests. I'd like to change these to src/main/java and src/test/java.

          Dunno, never thought about it.
          What else can it be if not java?
          Probably this comes in handy when you have multi-language project?

          If we eventually go this path,
          then you must change all of MC's subprojects. ;-)
          - http://www.jboss.org/jbossmc


          • 2. Re: Some Maven related changes
            Paul Gier Master

             

            "alesj" wrote:

            "pgier" wrote:

            Also, is there any reason not to change the directory names to follow the maven conventions? Currently we have src/main and src/tests. I'd like to change these to src/main/java and src/test/java.

            Dunno, never thought about it.
            What else can it be if not java?
            Probably this comes in handy when you have multi-language project?

            If we eventually go this path,
            then you must change all of MC's subprojects. ;-)
            - http://www.jboss.org/jbossmc


            For microcontainer we wouldn't have anything other than Java. But if we use the standard maven directory names, then I can remove that config from the poms. Yes, it's most useful when you have multi language projects which includes stuff like javacc grammar files (src/main/javacc) like we have in the app server build.

            I'll plan on changing all the MC subproject directories also. And eventually the app server will change once it's fully migrated.

            • 3. Re: Some Maven related changes
              Adrian Brock Master

               

              "alesj" wrote:
              "pgier" wrote:
              I'd like to make a couple of changes in the microcontainer build. The first is to change the parent/aggregate relationship so that the pom in the root directory functions as the parent. This will be more like how the app server build and the aop maven build are set up, and more like how maven builds itself. The build subdirectory will then be just for creating the combined jar files.

              Isn't app server similar to what we have in MC?
              Component-matrix ~ build?

              But yeah, fine with me.
              Adrian (as now my first officer :-)?


              Okay with me captain. :-)

              I'd suggest doing this while Ales is on holiday to minimize the impact and
              before the branches get created for 2.0.x

              • 4. Re: Some Maven related changes
                Ales Justin Master

                 

                "pgier" wrote:

                For microcontainer we wouldn't have anything other than Java. But if we use the standard maven directory names, then I can remove that config from the poms. Yes, it's most useful when you have multi language projects which includes stuff like javacc grammar files (src/main/javacc) like we have in the app server build.

                I'll plan on changing all the MC subproject directories also. And eventually the app server will change once it's fully migrated.

                OK, you have green light to do it, all proposed changes.
                But starting on Thursday, when I'm already on holiday. :-)

                What about that release-pom.xml issue we never resolved?

                Keep us posted about the changes. ;-)

                "adrian@jboss.org" wrote:

                I'd suggest doing this while Ales is on holiday to minimize the impact and
                before the branches get created for 2.0.x

                Yup, good call. ;-)

                • 5. Re: Some Maven related changes
                  Paul Gier Master

                  I made the maven changes in svn for the main microcontainer kernel project. If this works ok for everyone, I'll do the other projects next week.

                  I noticed there is a log4j.properties file in some of the modules. Is this used?

                  • 6. Re: Some Maven related changes
                    Adrian Brock Master

                     

                    "pgier" wrote:

                    I noticed there is a log4j.properties file in some of the modules. Is this used?


                    Not anymore.