-
1. Re: Circular and self dependencies
Where is this "fix", in AbstractController?
Even if some context depends on itself, you shouldn't simply ignore it - in general state machine view.
It should be simply reported as unresolved dependency as before, no special treatment required.
I guess with classloading it could be different.
But then it should be dealt in the classloading sub-project,
not at the abstract state machine level. -
2. Re: Circular and self dependencies
Where is this "fix", in AbstractController?
It is in dependency Branch_2_0
The code above prevents a stack overflow when the same context is a dependency of the context being uninstalled. -
3. Re: Circular and self dependencies
"alesj" wrote:
Where is this "fix"
It looks like a fix to me. Before we've only had circular references on a different state
of itself. e.g. "this"
i.e. you can't inject "this" into a constructor ;-)
If the dependency is on the current state (whiich is what Thomas wants
for the circular references in the classloading), the previous uninstall code would loop. -
4. Re: Circular and self dependencies
"adrian@jboss.org" wrote:
It looks like a fix to me. Before we've only had circular references on a different state of itself. e.g. "this"
Kabir, can you also apply this to trunk please. -
5. Re: Circular and self dependencies
"alesj" wrote:
"adrian@jboss.org" wrote:
It looks like a fix to me. Before we've only had circular references on a different state of itself. e.g. "this"
Kabir, can you also apply this to trunk please.
Done https://jira.jboss.org/jira/browse/JBKERNEL-53
Thomas, in future please create JIRA issues in JBKERNEL for your commits there :-) -