Log in to follow, share, and participate in this community.
Thread Running tests within IntelliJ IDEA fails
Running tests within IntelliJ IDEA failsFileAssetTestCase.shouldBeAbleToReadFile() fails when running in from within IntelliJ IDEA Path to Test.properties is wrong when running tests from within IDEA Is: /home/ken/dev/git/shrinkwrap/s...
Contributing and Pushing changes on githubAfter a discussion with Aslak on IRC we see the need to clarify the routine for contributing changes now that ShrinkWrap is on Github. Currently we have landed on sending a pull request after the changes are c...
Revisiting the WebArchive APII still don't think we have the WebArchive API right. SHRINKWRAP-186 (META-INF target in a WebArchive) was just the tip of an iceburg. I think we need to step back and make sure we address the whole picture. What indi...
ShrinkWrap now housed at GitHubhttps://jira.jboss.org/browse/SHRINKWRAP-209 The authoritative repo is now: http://github.com/shrinkwrap/shrinkwrap R/W: http://github.com/shrinkwrap/shrinkwrap Anon: git://github.com/shrinkwr...
Container versions in extensionsWe are having a discussion in ARQ-200 about how to incorporate the supported container version into an integration. The discussion made us aware of the fact that ShrinkWrap doesn't include the version of the container...
ShrinkWrapStandardContext and Serializablehttps://jira.jboss.org/browse/SHRINKWRAP-198 Regarding the new Tomcat/ShrinkWrap deployment mechanism: StandardContext, the parent class of our extension, implements Serializable. Therefore, our ...
ArchiveAsset and Exportershttps://jira.jboss.org/browse/SHRINKWRAP-199 We never really got it right with ArchiveAsset. The Asset contract states that anything may be added to an archive, so long as it may be represented as a s...
Known locations inside spec archivesIf the idea is that a "container" maps a path inside the archive, I think we should agree on the following table which shows how each container is mapped inside each spec archive: JAR WAR EAR RAR ClassContain...
Lemma for documentationALR, As you and the ShrinkWrap community begin to shift your focus to documentation, I'd like to recommend a tool named Lemma [1], developed by Christian Bauer, that falls right into your cup of tea. Lemma tur...
Wire Protocol for Archive SerializationUse Case: Send an Archive<?> over a network or serialize to disk. I had a look and wanted to note some thoughts. At first glance, we think of the process being: Export as ZIP Write...
Thread SHRINKWRAP-163: Making the Archive name optional
SHRINKWRAP-163: Making the Archive name optionalKen's submitted a patch to: https://jira.jboss.org/browse/SHRINKWRAP-163 Some review. 1) JavaDocs. As noted in Ken's TODOs, yep, we'll put these in before commit. 2) ExtensionTyp...
Thread Introduce built-in support for bean archives
Introduce built-in support for bean archivesThe JSR-299 specification (CDI) introduces the concept of a bean archive as a variant of several existing Java EE archives: A library jar, EJB jar, application client jar or rar archive is a bean archive if it...
Discussion about SHRINKWRAP-102I'm guessing we want to introduce some sort of configuration object (probably with a fluent API) or remove the ExtensionLoader?
Proposal: tree structure for ArchiveThis is a proposal of a tree structure for the Archive. I've done some research and made basically a simplified version of the JSR 170/283 (Content Repository API for Java). So, this is what I've come up with: ...
Thread Shrinkwrap-120: Exception in ZIP Export leads to Deadlock
Shrinkwrap-120: Exception in ZIP Export leads to DeadlockI know this issue is already closed but I found a problem. If an exception occurs while reading the first content of the file, it will be empty and the deadlock occurs again. Should we reopen this issue or create anot...
Illegal pathWhat should happen if a user has, for example, an archive with a single entry "/test.properties" and then he adds another asset to "/test.properties/another/test2.properties". A IllegalArgumentException? Maybe we can ...
Access to directoriesIf you have an Archive with a single file (i.e. /somewhere/inside/test.properties), only one entry is created in the MemoryMapArchiveImpl. So, a call to Archive.contains(ArchivePaths.create("/somewhere/inside/")) will...
SHRINKWRAP-112: Unified Importer APIhttps://jira.jboss.org/jira/browse/SHRINKWRAP-112 The idea here is to build a unified view which delegates into our existing importer types. There's a discussion on the JIRA already (from when forums wer...
Thread SHRINKWRAP-118: Splitting up ResourceContainer
SHRINKWRAP-118: Splitting up ResourceContainerhttps://jira.jboss.org/jira/browse/SHRINKWRAP-118 This one's a bit more involved than our typical entry-level contributor issues, but we need to start chipping away at pending API changes and work towards gett...