Adding A Log4jService Reconfiguration MBean Notification?

[jiwils]

Would it be possible to add a MBean notification to the Log4jService when it reconfigures itself in a future version of JBoss AS? When appenders, filters, etc. are added programmatically (via MBeans), they can be lost if a reconifguration happens, but with a notification, they could be "reconfigured" as well.

It would be easy enough to write an aspect to call a custom notification broadcaster if reconfiguration occurs, but it seems like having the service do it explicitly is the right approach.

[dimitris]

Sure, put it as minor feature request in JIRA.

[jiwils]

JIRA Link: http://jira.jboss.com/jira/browse/JBAS-2449

[jiwils]

I am confused about one particular aspect of this solution...

How does the Log4jService MBean indicate via the implementation of NotificationBroadcaster.getNotificationInfo that it emits this new notification (or does it at all)?

I can see via the new Log4jService code that a notification is emitted, but the non-overridden implementation of NotificationBroadcaster.getNotificationInfo just returns an empty array by default. Furthermore, the Log4jService's XML descriptor (in jboss-service.xml) and the XMBean descriptor that it refers to do not appear to add this notification information.

Is there some functionality that I am missing, or is the implementation of the NotificationBroadcaster.getNotificationInfo method not a big deal (the code should work anyway)?

I ask because in the development of my own NotificationBroadcaster's, should I override the behavior provided by NotificationBroadcasterSupport, use a JBoss XML descriptor in some fashion, or is this a detail that I should not worry about?

[dimitris]

In jboss getNotificationInfo() is not overriden in most cases and client code normally doesn't rely on it. If you want your mbeans to be more "correct" then go ahead and implement it.