1 2 Previous Next 26 Replies Latest reply on Oct 2, 2008 10:18 AM by kabirkhan Go to original post
      • 15. Re: Some maven updates
        kabirkhan

        Once the new build is complete, will we need the thirdparty folder? In one way I like it (probably due to old habit), but having things duplicated seems unnecessary. In AS I like the thirdparty folder since it makes it easier to test new versions of thirdparty dependencies locally, but in aop we don't really have that many dependencies.

        • 16. Re: Some maven updates
          pgier

           

          "kabir.khan@jboss.com" wrote:
          "pgier" wrote:
          If you run the build from the main build directory you have to pass the parameter like this:
          ./build.sh -Dbuild.maven.opts=-DJROCKIT_HOME=/path/to/jrockit


          Otherwise it doesn't get through to the maven build.

          I added a build/build-release.sh to avoid having to remember that :-)


          I made a couple of improvements now to the jrockit handling so I think you won't need this anymore. You now have a few options.

          1. Add a local.properties file to the build directory and ant will pick it up and pass to maven.

          2. Call ./build.sh or ant from the build directory and pass
          -Djrockit.home=/path/to/jrockit


          3. Or if you are running "mvn" directly from the root directory or the aop directory you can use something like option 2
          mvn install -Djrockit.home=/path/to/jrockit


          Hopefully this makes things a little easier. I also updated the hudson configs so that they use the local.properties file like before.

          • 17. Re: Some maven updates
            pgier

             

            "kabir.khan@jboss.com" wrote:
            Once the new build is complete, will we need the thirdparty folder? In one way I like it (probably due to old habit), but having things duplicated seems unnecessary. In AS I like the thirdparty folder since it makes it easier to test new versions of thirdparty dependencies locally, but in aop we don't really have that many dependencies.

            We'll need it for a little while so that the tests scripts can still use it for their classpaths. But eventually I'll update the test scripts to generate their classpaths from the pom and then I think we won't need the thirdparty dir.

            • 18. Re: Some maven updates
              kabirkhan

              Hi Paul,

              As discussed earlier, I am splitting asintegration into some new modules. While updating the release script I noticed that there is no javadoc being generated in the mavenized build. The release build expects to find these under
              aop/output/api
              aspects/output/api
              etc.

              • 19. Re: Some maven updates
                kabirkhan

                Also, it seems that doing a mvn clean gets rid of ouput/eclipse-classes, so I need to do a full rebuild in Eclipse after that

                • 20. Re: Some maven updates
                  kabirkhan

                  Paul,

                  I've deployed an aop snapshot to the snapshot server, and have updated my local as build to use the new artifacts. The client jar seems to be missing:

                   [java] [INFO] Failed to resolve artifact.
                   [java]
                   [java] Missing:
                   [java] ----------
                   [java] 1) org.jboss.aop:jboss-aop-jdk50-client:jar:2.0.0-SNAPSHOT
                   [java]
                   [java] Try downloading the file manually from the project website.
                   [java]
                   [java] Then, install it using the command:
                   [java] mvn install:install-file -DgroupId=org.jboss.aop -DartifactId=jboss-aop-jdk50-client -Dversion=2.0.0-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file
                   [java]
                   [java] Alternatively, if you host your own repository you can deploy the file there:
                   [java] mvn deploy:deploy-file -DgroupId=org.jboss.aop -DartifactId=jboss-aop-jdk50-client -Dversion=2.0.0-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
                   [java]
                   [java] Path to dependency:
                   [java] 1) org.jboss.jbossas:jboss-as-thirdparty:pom:5.0.0-SNAPSHOT
                   [java] 2) org.jboss.aop:jboss-aop-jdk50-client:jar:2.0.0-SNAPSHOT
                   [java]
                   [java] ----------
                   [java] 1 required artifact is missing.
                   [java]
                   [java] for artifact:
                   [java] org.jboss.jbossas:jboss-as-thirdparty:pom:5.0.0-SNAPSHOT
                   [java]
                   [java] from the specified remote repositories:
                   [java] central (http://repo1.maven.org/maven2),
                   [java] repository.jboss.org (http://repository.jboss.org/maven2),
                   [java] snapshots.jboss.org (http://snapshots.jboss.org/maven2)
                   [java]
                   [java]
                   [java] [INFO] ------------------------------------------------------------------------
                   [java] [INFO] For more information, run Maven with the -e switch
                   [java] [INFO] ------------------------------------------------------------------------
                   [java] [INFO] Total time: 12 seconds
                   [java] [INFO] Finished at: Mon Sep 29 14:53:58 BST 2008
                   [java] [INFO] Final Memory: 27M/49M
                   [java] [INFO] ------------------------------------------------------------------------
                   [java] Java Result: 1
                  


                  What do I do to deploy that?

                  • 21. Re: Some maven updates
                    kabirkhan

                    Hmmm,

                    I see it is being uploaded under

                    [INFO] Retrieving previous build number from snapshots.jboss.org
                    Uploading: https://snapshots.jboss.org/maven2/org/jboss/aop/jboss-aop/2.0.0-SNAPSHOT/jboss-aop-2.0.0-20080929.135907-11-sources.jar
                    [INFO] Retrieving previous build number from snapshots.jboss.org
                    Uploading: https://snapshots.jboss.org/maven2/org/jboss/aop/jboss-aop/2.0.0-SNAPSHOT/jboss-aop-2.0.0-20080929.135907-11-client.jar
                    [INFO] Retrieving previous build number from snapshots.jboss.org
                    Uploading: https://snapshots.jboss.org/maven2/org/jboss/aop/jboss-aop/2.0.0-SNAPSHOT/jboss-aop-2.0.0-20080929.135907-11-client-sources.jar
                    [INFO] Retrieving previous build number from snapshots.jboss.org
                    Uploading: https://snapshots.jboss.org/maven2/org/jboss/aop/jboss-aop/2.0.0-SNAPSHOT/jboss-aop-2.0.0-20080929.135907-11-single.jar
                    


                    I will try to get rid of this from the as poms and see where that gets me
                     <dependency>
                     <groupId>org.jboss.aop</groupId>
                     <artifactId>jboss-aop-jdk50-client</artifactId>
                     <version>${version.org.jboss.aop}</version>
                     <mapping>
                     <componentId>jboss.aop</componentId>
                     </mapping>
                     </dependency>
                    


                    • 22. Re: Some maven updates
                      kabirkhan

                      That gets me bit further, but in my as poms I am including the following dependencies:

                       <dependency>
                       <groupId>org.jboss.aop</groupId>
                       <artifactId>jboss-asintegration-core</artifactId>
                       <version>${version.org.jboss.aop}</version>
                       </dependency>
                      
                       <dependency>
                       <groupId>org.jboss.aop</groupId>
                       <artifactId>jboss-asintegration-jmx</artifactId>
                       <version>${version.org.jboss.aop}</version>
                       </dependency>
                      
                       <dependency>
                       <groupId>org.jboss.aop</groupId>
                       <artifactId>jboss-asintegration-mc</artifactId>
                       <version>${version.org.jboss.aop}</version>
                       </dependency>
                      
                       <dependency>
                       <groupId>org.jboss.aop</groupId>
                       <artifactId>jboss-aop</artifactId>
                       <version>${version.org.jboss.aop}</version>
                       </dependency>
                      
                       <dependency>
                       <groupId>org.jboss.aop</groupId>
                       <artifactId>jboss-aop-aspects</artifactId>
                       <version>${version.org.jboss.aop}</version>
                       </dependency>
                      
                       <dependency>
                       <groupId>org.jboss.aop</groupId>
                       <artifactId>jrockit-pluggable-instrumentor</artifactId>
                       <version>${version.org.jboss.aop}</version>
                       </dependency>
                      
                       <dependency>
                       <groupId>org.jboss.aop</groupId>
                       <artifactId>pluggable-instrumentor</artifactId>
                       <version>${version.org.jboss.aop}</version>
                       </dependency>
                      


                      But the thirdparty/jboss/aop folder only gets the following jars
                      [kabir@~/sourcecontrol/jboss-head/build]
                      $ls -al ../thirdparty/jboss/aop/lib/
                      total 4880
                      drwxr-xr-x 10 kabir staff 340 29 Sep 16:02 .
                      drwxr-xr-x 4 kabir staff 136 29 Sep 16:02 ..
                      -rw-r--r-- 1 kabir staff 125660 29 Sep 16:02 jboss-aop-aspects-sources.jar
                      -rw-r--r-- 1 kabir staff 104051 29 Sep 16:02 jboss-aop-aspects.jar
                      -rw-r--r-- 1 kabir staff 934044 29 Sep 16:02 jboss-aop-sources.jar
                      -rw-r--r-- 1 kabir staff 1304506 29 Sep 16:02 jboss-aop.jar
                      -rw-r--r-- 1 kabir staff 1780 29 Sep 16:02 jrockit-pluggable-instrumentor-sources.jar
                      -rw-r--r-- 1 kabir staff 4140 29 Sep 16:02 jrockit-pluggable-instrumentor.jar
                      -rw-r--r-- 1 kabir staff 1713 29 Sep 16:02 pluggable-instrumentor-sources.jar
                      -rw-r--r-- 1 kabir staff 2936 29 Sep 16:02 pluggable-instrumentor.jar
                      


                      I am getting some errors that are not making much sense to me. What do they mean?
                       [java] [INFO] ------------------------------------------------------------------------
                       [java] [INFO] Building JBoss Application Server Thirdparty Build
                       [java] [INFO] task-segment: [package]
                       [java] [INFO] ------------------------------------------------------------------------
                       [java] [WARNING] POM for 'org.jboss.jbossas:jboss-as-system:pom:5.0.0-SNAPSHOT:compile' is invalid. It will be ignored for artifact resolution. Reason: Failed to validate POM for project org.jboss.jbossas:jboss-as-system at Artifact [org.jboss.jbossas:jboss-as-system:pom:5.0.0-SNAPSHOT:compile]
                       [java] [INFO] [enforcer:enforce {execution: enforce-versions}]
                       [java] [WARNING] POM for 'org.jboss.jbossas:jboss-as-system:pom:5.0.0-SNAPSHOT:compile' is invalid. It will be ignored for artifact resolution. Reason: Failed to validate POM for project org.jboss.jbossas:jboss-as-system at Artifact [org.jboss.jbossas:jboss-as-system:pom:5.0.0-SNAPSHOT:compile]
                       [java] [INFO] [dependency:sources {execution: download-sources}]
                       [java] [WARNING] POM for 'org.jboss.jbossas:jboss-as-system:pom:5.0.0-SNAPSHOT:compile' is invalid. It will be ignored for artifact resolution. Reason: Failed to validate POM for project org.jboss.jbossas:jboss-as-system at Artifact [org.jboss.jbossas:jboss-as-system:pom:5.0.0-SNAPSHOT:compile]
                       [java] [INFO] [jboss-license:download-licenses {execution: default}]
                       [java] [INFO] Downloading licenses
                       [java] [WARNING] Attempting to build MavenProject instance for Artifact (org.jboss.aop:jboss-asintegration-jmx:2.0.0-20080929.135907-2) of type: jar; constructing POM artifact instead.
                       [java] [WARNING] Attempting to build MavenProject instance for Artifact (org.jboss.aop:jrockit-pluggable-instrumentor:2.0.0-20080929.135907-2) of type: jar; constructing POM artifact instead.
                       [java] [WARNING] Attempting to build MavenProject instance for Artifact (org.jboss.aop:jboss-aop-aspects:2.0.0-20080929.135907-10) of type: jar; constructing POM artifact instead.
                      




                      • 23. Re: Some maven updates
                        kabirkhan

                        I had misspelled "asintegration" as "asinegration" in thirdparty/pom.xml

                         <dependency>
                         <groupId>org.jboss.aop</groupId>
                         <artifactId>jboss-asintegration-core</artifactId>
                         <version>${version.org.jboss.aop}</version>
                         <mapping>
                         <componentId>jboss.aop</componentId>
                         </mapping>
                         </dependency>
                        

                        Now I get more files, but I do not see the jboss-aop-client jar?
                        [kabir@~/sourcecontrol/jboss-head/build]
                        $ls -al ../thirdparty/jboss/aop/lib/
                        total 5264
                        drwxr-xr-x 16 kabir staff 544 29 Sep 16:08 .
                        drwxr-xr-x 4 kabir staff 136 29 Sep 16:08 ..
                        -rw-r--r-- 1 kabir staff 125660 29 Sep 16:08 jboss-aop-aspects-sources.jar
                        -rw-r--r-- 1 kabir staff 104051 29 Sep 16:08 jboss-aop-aspects.jar
                        -rw-r--r-- 1 kabir staff 934044 29 Sep 16:08 jboss-aop-sources.jar
                        -rw-r--r-- 1 kabir staff 1304506 29 Sep 16:08 jboss-aop.jar
                        -rw-r--r-- 1 kabir staff 18764 29 Sep 16:08 jboss-asintegration-core-sources.jar
                        -rw-r--r-- 1 kabir staff 22530 29 Sep 16:08 jboss-asintegration-core.jar
                        -rw-r--r-- 1 kabir staff 36870 29 Sep 16:08 jboss-asintegration-jmx-sources.jar
                        -rw-r--r-- 1 kabir staff 38918 29 Sep 16:08 jboss-asintegration-jmx.jar
                        -rw-r--r-- 1 kabir staff 31186 29 Sep 16:08 jboss-asintegration-mc-sources.jar
                        -rw-r--r-- 1 kabir staff 33154 29 Sep 16:08 jboss-asintegration-mc.jar
                        -rw-r--r-- 1 kabir staff 1780 29 Sep 16:08 jrockit-pluggable-instrumentor-sources.jar
                        -rw-r--r-- 1 kabir staff 4140 29 Sep 16:08 jrockit-pluggable-instrumentor.jar
                        -rw-r--r-- 1 kabir staff 1713 29 Sep 16:08 pluggable-instrumentor-sources.jar
                        -rw-r--r-- 1 kabir staff 2936 29 Sep 16:08 pluggable-instrumentor.jar
                        


                        • 24. Re: Some maven updates
                          kabirkhan

                          Mail from Paul:

                          "pgier" wrote:

                          The client jar is automatically deployed, but the name has changed, so the dependency will have to change also.
                          The "client" jar and "single" jar are now both deployed with the jboss-aop jar and just given a different classifier. So the dependency will have to look like this:
                          <dependency>
                           <groupId>org.jboss.aop</groupId>
                           <artifactId>jboss-aop</artifactId>
                           <version>2.0.0-SNAPSHOT</version>
                           <classifier>client</classifier>
                          </dependency>
                          



                          • 25. Re: Some maven updates
                            pgier

                             

                            "kabir.khan@jboss.com" wrote:
                            Hi Paul,

                            As discussed earlier, I am splitting asintegration into some new modules. While updating the release script I noticed that there is no javadoc being generated in the mavenized build. The release build expects to find these under
                            aop/output/api
                            aspects/output/api
                            etc.


                            I have now added the javadoc generation to the maven builds during a release.

                            • 26. Re: Some maven updates
                              kabirkhan

                              Thanks, it seems fine now

                              1 2 Previous Next