signal on ended token

[camunda]

A signal on an already ended token should throw an exception (but does not at the moment). See also related https://jira.jboss.org/jira/browse/JBPM-1471.

Anybody mind if I add this to the core (jbpm 3.3.HEAD)?

Cheers
Bernd

[tom.baeyens]

i don't mind, but sync with Alejandro and Thomas.

and make a very clear note about it in the release notes. as this is a backwards incompatible change. (i agree: a reasonable one)

[camunda]

Okay, I committed the change, the test suite still runs fine.

The comment in the release notes is a good thing, where I can add something to it?

[camunda]

Ah, and I created an own JIRA issue for it: https://jira.jboss.org/jira/browse/JBPM-2033

[fang0x0]

*Copied from post in mailing list*

Hi.

Are we considering the use case of "having non ended subprocesses, when
parent process is ended"?
With this solution, this would throw an exception, right?

"that you should not signal a process instrance that has been ended
sounds trivial to me" - Tom

well, that's what _jbpm itself_ does, when returning from subprocesses
to ended parent process.

good luck,
cvl

[camunda]

Hi cvl,

You still can have "non ended subprocesses, when the parent process is ended". Because of the additional fix proposed in https://jira.jboss.org/jira/browse/JBPM-1471 this is no problem, since an ended sub process only signals the super process if it is not ended.

This fix was necessary anyway, otherwise canceling a process instance (which cancels sub process instance, which notifies the parent) wouldn't have been possible any more.

Cheers
Bernd

[fang0x0]

Hi.

This is very good.

I somehow assumed (from comments), that the proposed fix was not accepted.

Thanks,
Good luck.