-
1. Re: signal on ended token
tom.baeyens Feb 9, 2009 7:13 AM (in response to camunda)i don't mind, but sync with Alejandro and Thomas.
and make a very clear note about it in the release notes. as this is a backwards incompatible change. (i agree: a reasonable one) -
2. Re: signal on ended token
camunda Feb 9, 2009 9:04 AM (in response to camunda)Okay, I committed the change, the test suite still runs fine.
The comment in the release notes is a good thing, where I can add something to it? -
3. Re: signal on ended token
camunda Feb 9, 2009 9:05 AM (in response to camunda)Ah, and I created an own JIRA issue for it: https://jira.jboss.org/jira/browse/JBPM-2033
-
4. Re: signal on ended token
fang0x0 Feb 10, 2009 3:22 AM (in response to camunda)*Copied from post in mailing list*
Hi.
Are we considering the use case of "having non ended subprocesses, when
parent process is ended"?
With this solution, this would throw an exception, right?
"that you should not signal a process instrance that has been ended
sounds trivial to me" - Tom
well, that's what _jbpm itself_ does, when returning from subprocesses
to ended parent process.
good luck,
cvl -
5. Re: signal on ended token
camunda Feb 10, 2009 6:49 AM (in response to camunda)Hi cvl,
You still can have "non ended subprocesses, when the parent process is ended". Because of the additional fix proposed in https://jira.jboss.org/jira/browse/JBPM-1471 this is no problem, since an ended sub process only signals the super process if it is not ended.
This fix was necessary anyway, otherwise canceling a process instance (which cancels sub process instance, which notifies the parent) wouldn't have been possible any more.
Cheers
Bernd -
6. Re: signal on ended token
fang0x0 Feb 10, 2009 7:17 AM (in response to camunda)Hi.
This is very good.
I somehow assumed (from comments), that the proposed fix was not accepted.
Thanks,
Good luck.