Facing a weird issue while deploying my resource adapter as a module in Teiid8.4Final and JBossEAP6.1Alpha

[jamit]

Hi Team,

I am trying to deploy my existing rar file as a module by creating a jar,META-INF,MANIFEST.MF,ra.xml into a module say"mymodule" in the resource-adapter folder.

Made respective changes to the standalone resource adapter subsystem as well like instead of using <archive> used <module> etc..

The module gets detected and then Jboss throws an exception as follows:

16:46:48,210 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-8) MSC00001: Failed to start service jboss.ra.deployment.openworks_1: org.jboss.msc.service.StartException in service jboss.ra.deployment.openworks_1: org.jboss.msc.service.StartException in anonymous service: JBAS010446: Failed to start RA deployment [openworks]

  at org.jboss.as.connector.services.resourceadapters.deployment.ResourceAdapterXmlDeploymentService.start(ResourceAdapterXmlDeploymentService.java:131)

  at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc-1.0.4.GA.jar:1.0.4.GA]

  at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc-1.0.4.GA.jar:1.0.4.GA]

  at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [rt.jar:1.7.0_05]

  at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [rt.jar:1.7.0_05]

  at java.lang.Thread.run(Unknown Source) [rt.jar:1.7.0_05]

Caused by: org.jboss.msc.service.StartException in anonymous service: JBAS010446: Failed to start RA deployment [openworks]

  at org.jboss.as.connector.services.resourceadapters.deployment.ResourceAdapterXmlDeploymentService.start(ResourceAdapterXmlDeploymentService.java:115)

  ... 5 more

Caused by: org.jboss.jca.deployers.common.DeployException: IJ020063: Invalid connection factory implementation: com.lgc.ow.teiid.connect.OWTConnectionFactoryImpl

  at org.jboss.jca.deployers.common.AbstractResourceAdapterDeployer.createObjectsAndInjectValue(AbstractResourceAdapterDeployer.java:1864)

  at org.jboss.as.connector.services.resourceadapters.deployment.ResourceAdapterXmlDeploymentService$AS7RaXmlDeployer.doDeploy(ResourceAdapterXmlDeploymentService.java:183)

  at org.jboss.as.connector.services.resourceadapters.deployment.ResourceAdapterXmlDeploymentService.start(ResourceAdapterXmlDeploymentService.java:108)

  ... 5 more

16:46:48,266 INFO  [org.teiid.RUNTIME] (ServerService Thread Pool -- 45) TEIID50006 Teiid translator "intersystems-cache" added.

The class hierachy is as follows:

-- public class OWTConnectionFactoryImpl extends BasicConnectionFactory implements OWTConnectionFactory

-- public class OWTConnectionImpl extends BasicConnection implements OWTConnection

Implementation of managed factory as follows:

-- public class OWTManagedConnectionFactory extends BasicManagedConnectionFactory {

@Override

  public BasicConnectionFactory createConnectionFactory() throws ResourceException {

          return new OWTConnectionFactoryImpl(user, password, sid, project);

........

....

  }

}

The same code works fine if deployed as a rar file in teiid 8.4 Final and previous versions of Teiid 8.3 as well.

Would be great to have some expert guidance on this.

(My observation : when compared with the adapters like mongodb or ldap,the jar had only classes extending BasicManagedConnectionFactory and  BasicConnection.

Didnot see an impl for BasicConnectionFactory as done in my adapter).

Thanks

Amit

.

[rareddy]

Check if your connection factory has any getter/setter methods based on primitives, it should always be objects.

[jamit]

Yes there is a method which returns boolean,but this works with the .rar file approach.

Is this something specific when we want to deploy that as a module?

[rareddy]

With 8.4 you are deploying in the EAP 6.1 Alpha, with 8.3 you were using JBoss AS 7.1.1. I believe AS fixed that bug between those versions. It has no bearing whether it was deployed as rar vs module.

[jamit]

Yes you are correct with the 8.3 and AS 7.1.1.

But the rar file works seamlessly with Teiid8.4 Final and JBossEAP 6.1 alpha,if set as <archive> but fails with module.Is there an issue around this?

[rareddy]

As I mentioned there should be no difference between archive or module, at least I have not seen before. But you are saying otherwise with JBoss EAP 6.1 Alpha. AFAIK, there is no workaround.

You options are

1) Changing the code? and then deploy as RAR or module.

2) Deploy as RAR. Deploying as module based resource adapter is some artificial restriction we imposed Teiid project so that kit seems inclusive, but deploying as RAR is equally valid. So my question to you why do need to deploy your resource adapter as module?

Ramesh..

[anilallewar]

Ramesh,

We have issues with adding a resource adapter on the fly without restarting the server; so we want to deploy the rar as a module so that we can add connections on the fly for the module without needing to restart the server.

We got around the issue with adding resource adapter without having to restart the server by copying the rar as a separate archive and then having single connection per rar; but this is leading to memory issues when we have large number of connections. That is why we want to move the rar to a module so that we use just 1 classloader and also don't need to restart the server after adding a new connection.

Anil

[rareddy]

Anil,

One connection per <resource-adapter> configuration is imposed by [AS7-4776] Error during (re) adding connection factory using CLI - JBoss Issue Tracker

so that you can avoid restart.

It does matter if was deployed as RAR or module based, both should work same if you hand edit the standalone.xml. Yes it going to make difference if you programatically delete and add, in that case when you add second time if the first archive exists it may complain that it already exists, unless you rename the archive Module based does not have this hassle, as this is simply configuration based. I am not certain, what JBoss AS does when large number of multiple module based connections deployed, I suspect it may be still lead to memory issues, as it effectively treats each as single instance of archive. I would be curious to know what you find out, please let us know.

Ramesh..

[anilallewar]

Ramesh,

We also have the same requirement to be able to add the connection definitions using CLI and implemented this workaround to avoid restarting JBoss.

I will try debugging through the IronJacamar code and hopefully be able to fix the issue. Once that is done, we will take a look to add multiple connections to the module. My assumption was that since for the archive, we need to make a copy of the archive that needs to be loaded by a separate classloader we are having memory issues. With the module since we can add multiple connections without making copies, we should not have issue with copy of classes loaded in classloader per copy of archive.

I'll keep you posted regarding the findings.

Anil

[rareddy]

Anil,

You may be right on the class loader issue, i have not pushed them enough to break myself. IronJacmar team told me in the past this was big enough change they wanted to do in a separate release than I was asking in. I suggest opening a thread/JIRA and follow up before spending any time.

Ramesh..

[anilallewar]

Ramesh,

The issue with the module was a set of dependency that wasn't straightforward; once we fixed that we were able to deploy the resource adapter as a module.

Once we switched to using the RA as a module, we were able to deploy twice as many connection definitions that we were doing currently; so there seems to be some advantage in using RA as a module rather than an archive. I am assuming this could be because of the classloader being inherited for a module where as for an archive, you would need to physically load the classes in the resource adapter classloader for each connection definition.

As you suggested hopefully with Ironjacamer 2; we would have the capability to create and deploy connection definitions for the resource adapter without having to restart the server. As of now the one connection per resource adapter defined as a module seems to work fine for us.

Anil

[rareddy]

Great! Thanks for letting us know about your findings.

What is high water mark you tested?

[anilallewar]

We were able to successfully deploy about 500 connection definitions (min=2, max=20, prefill=true) using 4 GB of RAM with around 1.5 GB RAM free for processing. The resource adapter also uses recovery and has a custom recovery plugin.

Anil