1 2 3 Previous Next 32 Replies Latest reply on Jun 22, 2015 6:07 PM by jayzou01 Go to original post
      • 15. Re: Help with picketlink and return url
        tim.kutz

        Anil Saldhana wrote:

         

        Tim Kutz wrote:

         

        Update: I am able to get query string values to pass over and come back.  Form posts remain a problem, however.

         

        Anil, we would be happy to share this as a code contribution, just let me know how to submit it as a contribution.

        Tim, when we have time, we will take a look at the issues you mention. We are working on other things at the moment.

        Code contribution is as simple as git fork and sending a pull request.

        Hi Anil -

         

        I've packaged my code up into github, and you have a pull request waiting.  Feel free to hit me up with questions or comments.  The code I submitted supports pass-through of query-string parameters, but does not support form POST methods, which is probably a worthy addition at some point.  I added a unit test method in the already existing SAML2AuthenticationHandlerUnitTestCase JUnit class which passes, as well.

         

        Tim

        • 16. Re: Help with picketlink and return url
          pcraveiro

          Hi Tim,

           

              Can you update your fork and test the following PR ?

           

           

              I've closed your PR, see the comments for more details. (https://github.com/picketlink/federation/pull/150#issuecomment-10569826)

           

          Thanks.
          Pedro Igor

          • 17. Re: Help with picketlink and return url
            moosetraveller

            Hi Tim

             

            Thank you for your input!! I will follow PLINK-14 and this thread day by day, and hope for a speedy bugfix in PL.

             

            To all others; please vote on:

            https://issues.jboss.org/browse/PLINK-74

             

            Danke vielmals!

            Thomas

            • 18. Re: Help with picketlink and return url
              tim.kutz

              Pedro Igor wrote:

               

              Hi Tim,

               

                  Can you update your fork and test the following PR ?

               

               

                  I've closed your PR, see the comments for more details. (https://github.com/picketlink/federation/pull/150#issuecomment-10569826)

               

              Thanks.
              Pedro Igor

               

              I tried to pull and build with this, but my build is failing, in the as7 bindings module, with the following error:

               

              [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile (default-compile) on project picketlink-jbas7-single: Compilation failure

              [ERROR] error: Cannot read org.picketlink.identity.federation package files, cause : java.io.FileNotFoundException: org.picketlink.identity.federation/PicketLinkMessages

               

              Unfortunately, I don't know enough about PicketLink to easily resolve this.  Any advice you might have would be welcome.  If it's easier, I could also accept a built jar, that I could plug into our environment to test for you.

              • 19. Re: Help with picketlink and return url
                pcraveiro

                Ok Tim,

                 

                    Attached the jar files to https://issues.jboss.org/browse/PLINK-74.

                 

                Regards.

                Pedro Igor

                • 20. Re: Help with picketlink and return url
                  tim.kutz

                  Thank you, Pedro.

                   

                  This patch does solve the forwarding issue.  I've run several additional tests, and things appear to be working correctly, but being as this is a Snapshot, I'm hesitant to go live with it.  Can you share anything about the current timeline for a 2.1.6 release, so we can gauge our ability to wait for a production stable release?

                  • 21. Re: Help with picketlink and return url
                    pcraveiro

                    Hi Tim,

                     

                        We're going to release 2.1.6.Final this week. Maybe tomorrow.

                     

                    Regards.
                    Pedro Igor

                    • 22. Re: Help with picketlink and return url
                      kreichert

                      I have been working with PicketLink and need the functionality that this bugifx provides.  I have applied this change to our 2.1.5 build, but I am not having any success with it.  In my case I am trying to access a protected .jsp page.  Redirecting to the IdP and signing in is successful, but when I am returned to the picketlink ACS URL, I get an IllegalStateException:

                       

                      java.lang.IllegalStateException

                              at org.apache.catalina.connector.ResponseFacade.sendError(ResponseFacade.java:407)

                              at org.apache.catalina.servlets.DefaultServlet.serveResource(DefaultServlet.java:701)

                              at org.apache.catalina.servlets.DefaultServlet.doGet(DefaultServlet.java:332)

                       

                      I looked into this further, and I believe this is because this bugfix does not prevent the request from continuing to be processed after authentication succeeds and response.sendRedirect() is called in the authenticator.  The IllegalStateException occurs when the request is later processed and tries to add to the response, which has already been committed to send a redirect by the sendRedirect() call.

                       

                      I looked into the Tomcat FormAuthenticator for an example of how this should work and I have put together an improvement to this patch that does not cause the IllegalStateException, and also handles preserving POST requests.  This is done by failing authentication initially and sending the redirect, and then allowing authentication to succeed in the redirect and restoring the request at that point.  I would like to get this into the baseline if possible; are there instructions for how to submit a patch somewhere?  I'm not very familiar with git.

                      • 23. Re: Help with picketlink and return url
                        pcraveiro

                        Hi Kelvin,

                         

                            If you have a patch you can try to attach it to https://issues.jboss.org/browse/PLINK-74..

                         

                             Our git repo is located at: https://github.com/picketlink/federation

                         

                             I'm going to release today 2.1.6.Final. Will try to reproduce your scenario and if possible, fix it.

                         

                        Thanks in advance.

                        Pedro Igor

                        • 24. Re: Help with picketlink and return url
                          kreichert

                          Pedro-

                           

                          I have forked the federation project and pushed in my code update.  There should be a pull request waiting-

                           

                          Kevin

                          • 25. Re: Help with picketlink and return url
                            didier2011

                            Hi, Kevin,

                             

                            what happened with your pull request, when will it be released?

                             

                            Dieter

                            • 26. Re: Help with picketlink and return url
                              trogers-rh

                              Dieter Tengelmann wrote:

                               

                              Hi, Kevin,

                               

                              what happened with your pull request, when will it be released?

                               

                              Dieter

                               

                              It looks like Kevin's PR was included in version 2.1.7 Final.

                               

                               

                              Travis

                              • 27. Re: Help with picketlink and return url
                                traivor

                                I've updated to 2.1.8.Final in AS 7.1.1.Final's module but still see this problem. Is there some additional magic required?

                                • 28. Re: Help with picketlink and return url
                                  traivor

                                  I'm using this with JSF if that makes any difference.

                                  • 29. Re: Help with picketlink and return url
                                    glkishore

                                    I am facing the same issue. I am using jboss 7.1.1 and picketlink 2.1.8.  Are there any solution for this issue?