Log4j 1 and 2 Teiid Logger implementations

[gary.gregory]

Hi All:

I use Teiid Embedded in two projects. One with Log4j 1, and the other with version 2.

I see inLogging in Teiid that Teiid supports Log4j 1 but I do not see this Logger implemetation in Teiid Embedded. The only Logger implementation I found in Teiid Embedded is for JUL.

I have Teiid Logger implementations for Log4j version 1 and version 2 I am willing to donate to make logging to Log4j simpler out the box.

Is this something the Teiid project is interested in? Just like any other dependency, dependency on Log4j is optional until you actually use these classes.

Thank you,

Gary

[shawkins]

> I see inLogging in Teiid that Teiid supports Log4j 1 but I do not see this Logger implemetation in Teiid Embedded.

That is correct the log4j support is indirect through JBoss Logging in AS/EAP.  Another option is to enable JBoss Logging in Teiid embedded, but use the target logging framework of choice.

> Is this something the Teiid project is interested in? Just like any other dependency, dependency on Log4j is optional until you actually use these classes.

Yes we can certainly take a look at what you have.

[shawkins]

> Another option is to enable JBoss Logging in Teiid embedded, but use the target logging framework of choice.

To expand on that we don't currently provide the JBossLogger in embedded, but the engine already has a dependency on JBoss Logging so we could easily add it.

[gary.gregory]

Here you go:

• TEIID-3719 Add Log4j 1 Logger Adapter
• TEIID-3718 Add Log4j 2 Logger Adapter

Gary

[shawkins]

Thanks Gary.  We're going to look things over and see whether it makes sense to pull in these changes or just promote the usage of JBoss Logging.  It doesn't look like our version 3.1.4 of JBoss Logging has something explicit for Log4j 2, but it was added for 3.2 - [JBLOGGING-95] Add first-class support for Log4j 2 by beamerblvd · Pull Request #9 · jboss-logging/jboss-logging · GitHu…