This content has been marked as final.
Show 2 replies
-
1. Re: Arquillian available port extension
bmajsak Jan 21, 2016 3:42 PM (in response to mryan43)Hi Manuel,
sorry for the silence for that long Many thanks for your contribution and (long awaited) welcome in the community.
Give me a few days to have a look and I will definitely come back with feedback. I think such a functionality would be pretty useful for Arquillian Core. I will get in touch with aslak and we will figure out if your contribution can make it to the core module or will be available as an extension.
-
2. Re: Arquillian available port extension
bmajsak Oct 18, 2016 2:08 PM (in response to mryan43)Hi,
I looked at the code and I have few suggestions:
- port scanning is rather an exhaustive operation - we should make it with the lowest possible timeout and in parallel
- simple Socket should be enough - no need for ServerSocket here
- we should log which port is replaced
Since this is very tiny extension maybe putting it in arquillian-showcase would do the job? mjobanek any suggestions?