-
1. Re: Scrollable Datatable rows attribute and pagination
vijayamaladoss Nov 19, 2008 9:02 AM (in response to vijayamaladoss)Any suggestions/solutions ??
-
2. Re: Scrollable Datatable rows attribute and pagination
ilya_shaikovsky Nov 19, 2008 9:11 AM (in response to vijayamaladoss)1) please paste full page code.
2) use 3.1.6 version even if this not helps in this concrete case. It's difficult just to check how many issues gone between 3.1.2 and 3.1.6 -
3. Re: Scrollable Datatable rows attribute and pagination
vijayamaladoss Nov 19, 2008 10:09 AM (in response to vijayamaladoss)Thanks for the reply.
I have question about 3.1.6.
Are you talking about 3.1.6 SR1 release/ 3.1.6 GA release ?
We actually tried 3.2.2 GA and this didn't help.
I am afraid to clutter this forum with my 400+ lines of xhtml file :)
Alternatively, can you give a clue of why this problem can happen ?
Thanks once again. -
4. Re: Scrollable Datatable rows attribute and pagination
ilya_shaikovsky Nov 19, 2008 10:24 AM (in response to vijayamaladoss)do you have any client side errors?
could you see the request actually fired (in fireBug for example)? -
5. Re: Scrollable Datatable rows attribute and pagination
mvitenkov Nov 19, 2008 11:28 AM (in response to vijayamaladoss)Hi, vijayamaladoss.
I reproduced the same issue as you describe under newest richfaces 3.3.0-SNAPSHOT, seam 2.0.2.GA & Jboss 4.2.GA.
SDT Scroll down doesn't really bring back records, out of number defined in "rows" attribute.
Following bug was posted in JIRA:
https://jira.jboss.org/jira/browse/RF-4988
Thanks for participation. -
6. Re: Scrollable Datatable rows attribute and pagination
echavet Nov 19, 2008 11:51 AM (in response to vijayamaladoss)I have a similar problem with the ScrollableDataTable.
I think I have identified the problem:
The methode checkRange in class org.richfaces.component.UISrollableDataTable calls thesetFirst(0)
method when boolean condition:(getRowCount() < getFirst() + rows)
is true. Which seems to be an error (for me).
Eric Chavet -
7. Re: Scrollable Datatable rows attribute and pagination
vijayamaladoss Nov 20, 2008 12:26 AM (in response to vijayamaladoss)Thanks for logging this is as a JIRA issue Mikhail.
Is there any tentative dates for fixing this issue ?
Thanks a lot once again. -
8. Re: Scrollable Datatable rows attribute and pagination
echavet Nov 20, 2008 8:15 AM (in response to vijayamaladoss)After a modification of the checkRange method, the component is ok for me.
-
9. Re: Scrollable Datatable rows attribute and pagination
mvitenkov Nov 20, 2008 8:59 AM (in response to vijayamaladoss)Hi, Vilaym.
Bug is in queue, as soon as possible it will be fixed.
There are no tentative dates yet.
Thanks. -
10. Re: Scrollable Datatable rows attribute and pagination
vijayamaladoss Dec 3, 2008 9:50 AM (in response to vijayamaladoss)Hi echavet,
Can you please post the code for checkrange method that has been changed to fix this ?
Thanks -
11. Re: Scrollable Datatable rows attribute and pagination
echavet Dec 4, 2008 4:46 AM (in response to vijayamaladoss)package org.richfaces.component
class UIScrollableDataTable
The problem comes from the setFirst(0) instruction.
The original code is
line 443 : if (getRowCount() < getFirst() + rows) {
replace it by:
if (getFirstgetRowCount()<getFirst()) {
(wich should never happen!)
This does correct the bug. But I didn't know how to use the setScrollPos method so I did not make a good correction. -
12. Re: Scrollable Datatable rows attribute and pagination
vijayamaladoss Dec 4, 2008 1:31 PM (in response to vijayamaladoss)Thanks a lot Eric for your reply
I beleive when we scrolldown the pagination action calls the
processDecodes and this method bring backs the record and refreshes the view.
When I tried debugging by scrolling to see the 9th record with rows attribute set to 8, this processDecodes was not firing at all. This means that the request was not at all sent.
The point I am wondering how checkrange method fix will help here.
Sorry if I am wrong here.
And regarding the fix do u want to replace the below codeif (getRowCount() < getFirst() + rows) { setFirst(0); setScrollPos("0,0," + rows); }
byif (getRowCount() < getFirst()) { setFirst(0); setScrollPos("0,0," + rows); }
Am I interpreting this correctly ?
Please confirm.
Thanks a lot once again.
Vijay -
13. Re: Scrollable Datatable rows attribute and pagination
echavet Dec 5, 2008 3:35 AM (in response to vijayamaladoss)Hi,
yes the code replacement is the one that worked for me.
But take care, the only modification done is to prevent the call of the setFirt(0) method when the last page number of rows is lower then the row attribute value. I think this was an error. But my correction introduces kind of dead code... so I could not understand what this code was originaly made for.
I can't remember what was the symptoms... all I can tell you is that if your second page number of rows is lower than 8 then you are in the case where the setFirt(0) method is called. Which ends up with the firt page being displayed again or the request being ignored (this is what I can't remember).
The best is to try it. -
14. Re: Scrollable Datatable rows attribute and pagination
vijayamaladoss Dec 8, 2008 8:58 AM (in response to vijayamaladoss)I tried the fix. But that doesnt work.
The event itself is not fired.
Richfaces team is there any fix available ?
We need this badly as our whole application is using ScrollableDataTable and we are in verge to go to production and this is a critical bug that is stopping us.
Reverting back to Datatable + Datascroller is costly and there are quiet a lot of styling differences between datatable and scrollableDataTable.