Scrollable Datatable rows attribute and pagination

[vijayamaladoss]

Hi,

We are using richfaces 3.1.2 GA along with Seam 2.0 GA in Jboss 4.2. The problem we have is we have defined the rows attributes in the scrollable data table. We expect rows will be dynamically fetched when a table is scrolled up and down.

The problem we face is, suppose we have total number of records as 9 and we set the rows attribute to 8, the scroll down event doesn't bring back the last record. I assume the event is fired but the client is not refreshing.

<rich:scrollableDataTable
rowKeyVar="rkv" headerClass="DataTableHeader"
columnClasses="DataTableColumnsOdd, DataTableColumnsEven"
height="190px" width="960px" id="prpList" rows="5"
value="#{beanList}" var="prpty" reRender="prpList"
hideWhenScrolling="true">

We tried even with latest richfaces distribution and it didnt work

Any clues ?

Thanks

[vijayamaladoss]

Any suggestions/solutions ??

[ilya_shaikovsky]

1) please paste full page code.

2) use 3.1.6 version even if this not helps in this concrete case. It's difficult just to check how many issues gone between 3.1.2 and 3.1.6

[vijayamaladoss]

Thanks for the reply.

I have question about 3.1.6.
Are you talking about 3.1.6 SR1 release/ 3.1.6 GA release ?

We actually tried 3.2.2 GA and this didn't help.

I am afraid to clutter this forum with my 400+ lines of xhtml file :)
Alternatively, can you give a clue of why this problem can happen ?

Thanks once again.

[ilya_shaikovsky]

do you have any client side errors?

could you see the request actually fired (in fireBug for example)?

[mvitenkov]

Hi, vijayamaladoss.
I reproduced the same issue as you describe under newest richfaces 3.3.0-SNAPSHOT, seam 2.0.2.GA & Jboss 4.2.GA.

SDT Scroll down doesn't really bring back records, out of number defined in "rows" attribute.
Following bug was posted in JIRA:
https://jira.jboss.org/jira/browse/RF-4988

Thanks for participation.

[echavet]

I have a similar problem with the ScrollableDataTable.
I think I have identified the problem:
The methode checkRange in class org.richfaces.component.UISrollableDataTable calls the

setFirst(0)

method when boolean condition:

(getRowCount() < getFirst() + rows)

is true. Which seems to be an error (for me).
Eric Chavet

[vijayamaladoss]

Thanks for logging this is as a JIRA issue Mikhail.
Is there any tentative dates for fixing this issue ?

Thanks a lot once again.

[echavet]

After a modification of the checkRange method, the component is ok for me.

[mvitenkov]

Hi, Vilaym.

Bug is in queue, as soon as possible it will be fixed.
There are no tentative dates yet.

Thanks.

[vijayamaladoss]

Hi echavet,

Can you please post the code for checkrange method that has been changed to fix this ?

Thanks

[echavet]

package org.richfaces.component
class UIScrollableDataTable

The problem comes from the setFirst(0) instruction.

The original code is
line 443 : if (getRowCount() < getFirst() + rows) {

replace it by:
if (getFirstgetRowCount()<getFirst()) {
(wich should never happen!)

This does correct the bug. But I didn't know how to use the setScrollPos method so I did not make a good correction.

[vijayamaladoss]

Thanks a lot Eric for your reply

I beleive when we scrolldown the pagination action calls the
processDecodes and this method bring backs the record and refreshes the view.

When I tried debugging by scrolling to see the 9th record with rows attribute set to 8, this processDecodes was not firing at all. This means that the request was not at all sent.

The point I am wondering how checkrange method fix will help here.
Sorry if I am wrong here.

And regarding the fix do u want to replace the below code

 if (getRowCount() < getFirst() + rows) {
 setFirst(0);
 setScrollPos("0,0," + rows);
 }

by

 if (getRowCount() < getFirst()) {
 setFirst(0);
 setScrollPos("0,0," + rows);
 }

Am I interpreting this correctly ?

Please confirm.

Thanks a lot once again.

Vijay

[echavet]

Hi,
yes the code replacement is the one that worked for me.
But take care, the only modification done is to prevent the call of the setFirt(0) method when the last page number of rows is lower then the row attribute value. I think this was an error. But my correction introduces kind of dead code... so I could not understand what this code was originaly made for.

I can't remember what was the symptoms... all I can tell you is that if your second page number of rows is lower than 8 then you are in the case where the setFirt(0) method is called. Which ends up with the firt page being displayed again or the request being ignored (this is what I can't remember).

The best is to try it.

[vijayamaladoss]

I tried the fix. But that doesnt work.

The event itself is not fired.

Richfaces team is there any fix available ?

We need this badly as our whole application is using ScrollableDataTable and we are in verge to go to production and this is a critical bug that is stopping us.

Reverting back to Datatable + Datascroller is costly and there are quiet a lot of styling differences between datatable and scrollableDataTable.